Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7364)

Unified Diff: chrome/common/logging_chrome.h

Issue 2901173002: Move RedirectChromeLogging to src/chromeos. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/logging_chrome.h
diff --git a/chrome/common/logging_chrome.h b/chrome/common/logging_chrome.h
index 58acda6723c445cee8b481211853b19cd1569b83..260f7003aeec1290ebadde105241cc29f832561c 100644
--- a/chrome/common/logging_chrome.h
+++ b/chrome/common/logging_chrome.h
@@ -32,15 +32,22 @@ namespace logging {
void InitChromeLogging(const base::CommandLine& command_line,
OldFileDeletionState delete_old_log_file);
+LoggingDestination DetermineLogMode(const base::CommandLine& command_line);
sky 2017/05/25 02:23:56 Given the return value, how about DetermineLogging
achuithb 2017/05/25 10:06:06 Done.
+
#if defined(OS_CHROMEOS)
xiyuan 2017/05/24 15:15:33 Move everything in this section to the new chrome/
achuithb 2017/05/24 21:07:55 These are all used by the platform-independent Ini
xiyuan 2017/05/24 21:16:19 Okay. :(
+// Point the logging symlink to the system log or the user session log.
+base::FilePath SetUpSymlinkIfNeeded(const base::FilePath& symlink_path,
+ bool new_log);
+
+// Remove the logging symlink.
+void RemoveSymlinkAndLog(const base::FilePath& link_path,
+ const base::FilePath& target_path);
+
// Get the log file directory path.
base::FilePath GetSessionLogDir(const base::CommandLine& command_line);
// Get the log file location.
base::FilePath GetSessionLogFile(const base::CommandLine& command_line);
-
-// Redirects chrome logging to the appropriate session log dir.
-void RedirectChromeLogging(const base::CommandLine& command_line);
#endif
// Call when done using logging for Chrome.

Powered by Google App Engine
This is Rietveld 408576698