Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: runtime/bin/snapshot_empty.cc

Issue 2901163002: Use assembly instead of C array literals to link the core snapshot into the VM. (Closed)
Patch Set: windows Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/run_vm_tests.cc ('k') | runtime/bin/snapshot_in.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/snapshot_empty.cc
diff --git a/runtime/bin/snapshot_empty.cc b/runtime/bin/snapshot_empty.cc
index 6508bd92d837f2ab138a1e2e972984b9dd9bd3fb..6629e07d450973eb53f52e467a8e45516c43e0d5 100644
--- a/runtime/bin/snapshot_empty.cc
+++ b/runtime/bin/snapshot_empty.cc
@@ -13,13 +13,9 @@ typedef unsigned __int8 uint8_t;
#endif
#include <stddef.h>
-namespace dart {
-namespace bin {
-
-const uint8_t* vm_snapshot_data = NULL;
-const uint8_t* vm_snapshot_instructions = NULL;
-const uint8_t* core_isolate_snapshot_data = NULL;
-const uint8_t* core_isolate_snapshot_instructions = NULL;
-
-} // namespace bin
-} // namespace dart
+extern "C" {
+const uint8_t* kDartVmSnapshotData = NULL;
+const uint8_t* kDartVmSnapshotInstructions = NULL;
+const uint8_t* kDartCoreIsolateSnapshotData = NULL;
+const uint8_t* kDartCoreIsolateSnapshotInstructions = NULL;
+}
« no previous file with comments | « runtime/bin/run_vm_tests.cc ('k') | runtime/bin/snapshot_in.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698