Issue 2901123002: clone of 2883903002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2901123002: clone of 2883903002 (Closed)

Created:
3 years, 7 months ago by scottmg

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

clone of 2883903002 Add service unittest for WakeLockServiceImpl. BUG=689410 patch from issue 2883903002 at patchset 20001 (http://crrev.com/2883903002#ps20001)

Patch Set 1 #

Patch Set 2 : . #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -2 lines)			Patch
M	services/device/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	services/device/unittest_manifest.json	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	services/device/wake_lock/DEPS	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	services/device/wake_lock/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	services/device/wake_lock/wake_lock_service_impl_unittest.cc	View	1 chunk	+203 lines, -0 lines	0 comments	Download
M	testing/buildbot/gn_isolate_map.pyl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scottmg

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-23 20:18:50 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901123002/20001

3 years, 7 months ago (2017-05-23 20:19:24 UTC) #2

The CQ bit was unchecked by scottmg@chromium.org

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages