Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2901103002: Fix closing namespace comments in //net. (Closed)

Created:
3 years, 7 months ago by Bence
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, gavinp+disk_chromium.org, fuzzing_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closing namespace comments in //net. Fix namespace comment issues identified by git cl lint. Review-Url: https://codereview.chromium.org/2901103002 Cr-Commit-Position: refs/heads/master@{#474377} Committed: https://chromium.googlesource.com/chromium/src/+/d479b3c2ca75e2508e2a2b3c661a9bfb746b4ef9

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -41 lines) Patch
M net/android/gurl_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/android/gurl_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/cache_type.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_sniffer_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/proxy_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/zap.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/zap.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_whitelist_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/parse_name_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/nss_profile_filter_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_cert_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_util_android.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/parsed_cookie.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/parsed_cookie_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_entry_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/record_parsed.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_multi_round_parse_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_security_headers_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/md4.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/md4.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/proxy_connect_redirect_http_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/transport_security_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_decider.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/reporting/reporting_service.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/threaded_ssl_private_key.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/test/embedded_test_server/default_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server_connection_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/test/url_request/url_request_slow_download_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dns_fuzz_stub/dns_fuzz_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/transport_security_state_generator/transport_security_state_entry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
Bence
zhongyi: PTAL. Thank you.
3 years, 7 months ago (2017-05-24 13:41:48 UTC) #12
Zhongyi Shi
lgtm!
3 years, 7 months ago (2017-05-24 16:57:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901103002/20001
3 years, 7 months ago (2017-05-24 17:10:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/446359)
3 years, 7 months ago (2017-05-24 17:21:25 UTC) #17
Bence
Ryan: PTAL, in particular at net/base/mime_sniffer_perftest.cc. Thanks. Zhongyi: Thank you for reviewing.
3 years, 7 months ago (2017-05-24 18:11:05 UTC) #19
Ryan Sleevi
lgtm
3 years, 7 months ago (2017-05-24 18:44:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901103002/20001
3 years, 7 months ago (2017-05-24 18:47:39 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 18:55:16 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d479b3c2ca75e2508e2a2b3c661a...

Powered by Google App Engine
This is Rietveld 408576698