Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2901093003: Revert of Update TextSelection for non-user initiated events (Closed)

Created:
3 years, 7 months ago by Changwan Ryu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update TextSelection for non-user initiated events (patchset #7 id:120001 of https://codereview.chromium.org/2856093003/ ) Reason for revert: We started to seeing terribly flaky ImeTest on Android after this commit (crbug.com/725532), so try reverting this one. Original issue's description: > Update TextSelection for non-user initiated events > > This makes Chromium Content API to be able to notify about text > selection changes triggered by non-user events (eg. JavaScript, IME, > autofill). > > R=creis@chromium.org,nasko@chromium.org,ekaramad@chromium.org > BUG=671986 > TEST=interactive_ui_tests > --gtest_filter=SitePerProcessTextInputManagerTest.NonUserInitiatedTextSelection > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2856093003 > Cr-Commit-Position: refs/heads/master@{#473834} > Committed: https://chromium.googlesource.com/chromium/src/+/d48794b9728276c1183b0c56f8cb7afe71b7bca4 TBR=creis@chromium.org,ekaramad@chromium.org,nasko@chromium.org,thestig@chromium.org,pvarga@inf.u-szeged.hu # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671986 Review-Url: https://codereview.chromium.org/2901093003 Cr-Commit-Position: refs/heads/master@{#474009} Committed: https://chromium.googlesource.com/chromium/src/+/44664cdc94553b40ccb9979ed4a99b57453b4de6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -284 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 4 chunks +24 lines, -148 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.h View 3 chunks +4 lines, -10 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/text_input_test_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/test/text_input_test_utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 3 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 8 chunks +37 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Changwan Ryu
Created Revert of Update TextSelection for non-user initiated events
3 years, 7 months ago (2017-05-23 19:13:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901093003/1
3 years, 7 months ago (2017-05-23 19:13:48 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 19:14:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44664cdc94553b40ccb9979ed4a9...

Powered by Google App Engine
This is Rietveld 408576698