📷 Create RenderTestRule which fails after test method finishes.

📷 Create RenderTestRule which fails after test method finishes.

This CL:
- Removes RenderUtils.
- Creates RenderTestRule with most of the RenderUtils functionality.
- Updates render tests to RenderTestRule.
- Removes the 'regenerate-goldens' flag. This is not needed because the
  RenderTestRule will throw an Exception once the test method has
  finished, so all image renders and diffs will be saved anyway.
- Simplifies the rendering logic.

BUG=614305
Review-Url: https://codereview.chromium.org/2901053003
Cr-Commit-Position: refs/heads/master@{#474978}
Committed: https://chromium.googlesource.com/chromium/src/+/1c831a5af48331b017f2bf3d6a07abb40f143626

[PEConn, 2017-05-24 16:08:29]

peconn@chromium.org changed reviewers:
+ bauerb@chromium.org, jbudorick@chromium.org, mikecase@chromium.org

[PEConn, 2017-05-24 16:08:30]

PTAL!

[Bernhard Bauer, 2017-05-25 10:23:18]

LGTM

https://codereview.chromium.org/2901053003/diff/1/chrome/test/android/javates...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java
(right):

https://codereview.chromium.org/2901053003/diff/1/chrome/test/android/javates...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java:94:
private List<String> mMatchIds = new LinkedList<>();
We're not actually doing anything with the matches.

[jbudorick, 2017-05-25 13:10:32]

lgtm

[PEConn, 2017-05-26 09:19:08]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2017-05-26 09:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2901053003/#ps40001
(title: "Typo in comment.")

[commit-bot: I haz the power, 2017-05-26 09:19:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 10:25:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495790348701040,
"parent_rev": "424fd27db211d380ddc81f09f0f35b71661e6cdf", "commit_rev":
"1c831a5af48331b017f2bf3d6a07abb40f143626"}

[commit-bot: I haz the power, 2017-05-26 10:25:59]

Description was changed from

==========
📷 Create RenderTestRule which fails after test method finishes.

This CL:
- Removes RenderUtils.
- Creates RenderTestRule with most of the RenderUtils functionality.
- Updates render tests to RenderTestRule.
- Removes the 'regenerate-goldens' flag. This is not needed because the
  RenderTestRule will throw an Exception once the test method has
  finished, so all image renders and diffs will be saved anyway.
- Simplifies the rendering logic.

BUG=614305
==========

to

==========
📷 Create RenderTestRule which fails after test method finishes.

This CL:
- Removes RenderUtils.
- Creates RenderTestRule with most of the RenderUtils functionality.
- Updates render tests to RenderTestRule.
- Removes the 'regenerate-goldens' flag. This is not needed because the
  RenderTestRule will throw an Exception once the test method has
  finished, so all image renders and diffs will be saved anyway.
- Simplifies the rendering logic.

BUG=614305

Review-Url: https://codereview.chromium.org/2901053003
Cr-Commit-Position: refs/heads/master@{#474978}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c831a5af48331b017f2bf3d6a07...
==========

[commit-bot: I haz the power, 2017-05-26 10:26:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1c831a5af48331b017f2bf3d6a07...