Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2901043002: [Mac] Remove dead code in Profile Chooser Controller (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove dead code in Profile Chooser Controller BUG=723730 Review-Url: https://codereview.chromium.org/2901043002 Cr-Commit-Position: refs/heads/master@{#473990} Committed: https://chromium.googlesource.com/chromium/src/+/fb84eb9ae2b489a9ef2e8ed26db2d9bacb63e99d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -270 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 4 chunks +0 lines, -270 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-05-23 17:48:42 UTC) #8
Sidney San Martín
lgtm
3 years, 7 months ago (2017-05-23 17:55:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901043002/1
3 years, 7 months ago (2017-05-23 18:01:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445094)
3 years, 7 months ago (2017-05-23 18:11:11 UTC) #13
lgrey
Thanks! + mark for OWNERS
3 years, 7 months ago (2017-05-23 18:13:02 UTC) #15
Mark Mentovai
LGTM!
3 years, 7 months ago (2017-05-23 18:21:14 UTC) #16
lgrey
Thanks!
3 years, 7 months ago (2017-05-23 18:21:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901043002/1
3 years, 7 months ago (2017-05-23 18:22:34 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:28:44 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb84eb9ae2b489a9ef2e8ed26db2...

Powered by Google App Engine
This is Rietveld 408576698