Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3391)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2901023002: Disable learning text suggestions if in incognito. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index 12c8848c7ca170597f804ab9d52277fc560f734d..d64daf274669521f97dda5d5154ba0a8e548d0b1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -2249,15 +2249,18 @@ public class LocationBarLayout extends FrameLayout
updateSecurityIcon(getSecurityLevel());
}
- /**
- * @return The Tab currently showing.
- */
@Override
public Tab getCurrentTab() {
if (mToolbarDataProvider == null) return null;
return mToolbarDataProvider.getTab();
}
+ @Override
+ public boolean isIncognito() {
+ if (mToolbarDataProvider == null) return false;
Changwan Ryu 2017/05/23 19:47:47 We actually set an empty version in ToolbarLayout#
Ted C 2017/05/23 20:07:19 The null check here is for consistency with above.
Ted C 2017/05/23 21:09:15 Per the offline discussion, this was more around u
+ return mToolbarDataProvider.isIncognito();
+ }
+
private void initOmniboxResultsContainer() {
if (mOmniboxResultsContainer != null) return;

Powered by Google App Engine
This is Rietveld 408576698