Disable learning text suggestions if in incognito.

chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.omnibox;
 
 import static org.chromium.chrome.browser.toolbar.ToolbarPhone.URL_FOCUS_CHANGE_ANIMATION_DURATION_MS;
 
 import android.Manifest;
 import android.animation.Animator;
@@ skipping 2231 matching lines @@
      * Update the location bar visuals based on a loading state change.
      * @param updateUrl Whether to update the URL as a result of the this call.
      */
     @Override
     public void updateLoadingState(boolean updateUrl) {
         if (updateUrl) setUrlToPageUrl();
         updateNavigationButton();
         updateSecurityIcon(getSecurityLevel());
     }
 
-    /**
-     * @return The Tab currently showing.
-     */
     @Override
     public Tab getCurrentTab() {
         if (mToolbarDataProvider == null) return null;
         return mToolbarDataProvider.getTab();
     }
 
+    @Override
+    public boolean isIncognito() {
+        if (mToolbarDataProvider == null) return false;

[Changwan Ryu, 2017/05/23 19:47:47]

We actually set an empty version in ToolbarLayout#onFinishInflate(),
and set a real version after ToolbarLayout#initialize() which is part of post
inflation startup. If inputconnection is activated between the two calls, then
we may report the flag incorrectly, but likely not possible because
onFinishInflate() and initialize() will likely be called in one UI loop. Could
you confirm?

[Ted C, 2017/05/23 20:07:19]

The null check here is for consistency with above.  So this seems somewhat
orthogonal and whether we should investigate removing the null checks
entirely.

The reason I kept these here and I don't think it to be too terribly
unreasonable
is that these are called by Android methods on View/TextView.  I have no
control over whether the super constructor or onFinishInflate for TextView
will trigger an input connection create and thus call into this very early
in the construction flow before any of these calls you show are triggered.

So I guess I'm wondering what you want to be confirmed?

[Ted C, 2017/05/23 21:09:15]

Per the offline discussion, this was more around us opt-ing into keyboard
sharing when the state was unknown.  That is a great point and we shouldn't do
that.

Switched to default off until we can actually determine the incognito-ness.  All
the boolean logic should be inverted now.

+        return mToolbarDataProvider.isIncognito();
+    }
+
     private void initOmniboxResultsContainer() {
         if (mOmniboxResultsContainer != null) return;
 
         // Use the omnibox results container in the bottom sheet if it exists.
         int omniboxResultsContainerId = R.id.omnibox_results_container_stub;
         if (mBottomSheet != null) {
             omniboxResultsContainerId = R.id.bottom_omnibox_results_container_stub;
         }
 
         ViewStub overlayStub = (ViewStub) getRootView().findViewById(omniboxResultsContainerId);
@@ skipping 254 matching lines @@
     public void setTitleToPageTitle() { }
 
     @Override
     public void setShowTitle(boolean showTitle) { }
 
     @Override
     public boolean mustQueryUrlBarLocationForSuggestions() {
         return DeviceFormFactor.isTablet();
     }
 }