Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issue 2901013002: Merge 59: [Android WebAPK] Don't navigate WebAPK as a result of WindowClient.focus() (Closed)

Created:
3 years, 7 months ago by pkotwicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge 59: [Android WebAPK] Don't navigate WebAPK as a result of WindowClient.focus() This CL makes WindowClient.Focus() not navigate the WebAPK if the WebAPK is already open. When a user taps on a Twitter notification, the following race condition occurs: - The service worker uses postMessage() and the main page navigates by setting window.location.href - The service worker calls WindowClient.Focus(). This causes a navigation to the current page This CL will remove the race by making WindowClient.Focus() not do any navigation if the WebAPK is already running BUG=711011 Review-Url: https://codereview.chromium.org/2849873002 Cr-Original-Commit-Position: refs/heads/master@{#472327} Review-Url: https://codereview.chromium.org/2901013002 . Cr-Commit-Position: refs/branch-heads/3071@{#671} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/157c3636e9b9cf67981e699ada98a03432056210

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
pkotwicz
3 years, 7 months ago (2017-05-23 15:42:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
157c3636e9b9cf67981e699ada98a03432056210.

Powered by Google App Engine
This is Rietveld 408576698