Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2900973004: Move code in ComputedStyle::UpdatePropertySpecificDifferences to generate diffing helpers (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, nainar1, shend
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code in ComputedStyle::UpdatePropertySpecificDifferences to generate diffing helpers This patch moves code around in ComputedStyle::UpdatePropertySpecificDifferences to allow us to easily generate one diffing function helper per flag to be set on StyleDifference. BUG=710938 Review-Url: https://codereview.chromium.org/2900973004 Cr-Commit-Position: refs/heads/master@{#474571} Committed: https://chromium.googlesource.com/chromium/src/+/f77fd909021aefd1cb49085c1f98dea3259dbba1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -58 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +43 lines, -58 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
nainar
shend@, PTAL? Thanks!
3 years, 7 months ago (2017-05-24 12:05:57 UTC) #7
shend
lgtm
3 years, 7 months ago (2017-05-25 01:10:52 UTC) #8
nainar
meade@, PTAL? Thanks!
3 years, 7 months ago (2017-05-25 01:12:24 UTC) #10
meade_UTC10
lgtm FYI you misspelled pacth :p
3 years, 7 months ago (2017-05-25 05:39:06 UTC) #11
nainar1
On 2017/05/25 at 05:39:06, meade wrote: > lgtm > > FYI you misspelled pacth :p ...
3 years, 7 months ago (2017-05-25 05:41:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900973004/1
3 years, 7 months ago (2017-05-25 05:41:56 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 05:47:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f77fd909021aefd1cb49085c1f98...

Powered by Google App Engine
This is Rietveld 408576698