Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2900963002: cros: Add spoken feedback for dynamically populated information in migration UI. (Closed)

Created:
3 years, 7 months ago by fukino
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Add spoken feedback for dynamically populated information in migration UI. The dialog's title, subtitle, and buttons already have spoken feedback. However, some dynamic information (migration progress, battery level, available storage) do not have spoken feedback, so this CL adds them using aria-live attribute. BUG=715412 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2900963002 Cr-Commit-Position: refs/heads/master@{#474235} Committed: https://chromium.googlesource.com/chromium/src/+/4383f0e57903aed260b6057ddb9de83e53725b25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/encryption_migration.html View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fukino
Xiyuan, could you take a look?
3 years, 7 months ago (2017-05-23 11:35:04 UTC) #3
xiyuan
lgtm
3 years, 7 months ago (2017-05-23 14:45:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900963002/1
3 years, 7 months ago (2017-05-23 23:50:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/301480)
3 years, 7 months ago (2017-05-24 05:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900963002/1
3 years, 7 months ago (2017-05-24 08:10:23 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 10:02:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4383f0e57903aed260b6057ddb9d...

Powered by Google App Engine
This is Rietveld 408576698