Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2900953002: Syntax errors in three network traffic annotations corrected. (Closed)

Created:
3 years, 7 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Syntax errors in three network traffic annotations corrected. Syntax error corrected in network traffic annotations of: chrome/browser/extensions/install_signer.cc extensions/browser/updater/extension_downloader.cc BUG=656607 Review-Url: https://codereview.chromium.org/2900953002 Cr-Commit-Position: refs/heads/master@{#473964} Committed: https://chromium.googlesource.com/chromium/src/+/23912c2c5b51036910859aa8db07db2a86649d77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/extensions/install_signer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ramin Halavati
Devlin, I have corrected syntax errors in network traffic annotations, please review them. I am ...
3 years, 7 months ago (2017-05-23 07:45:32 UTC) #2
Devlin
lgtm. Is there a bug we can link? (The one for converting to network traffic ...
3 years, 7 months ago (2017-05-23 16:48:32 UTC) #3
Ramin Halavati
On 2017/05/23 16:48:32, Devlin (catching up) wrote: > lgtm. > > Is there a bug ...
3 years, 7 months ago (2017-05-23 16:51:36 UTC) #5
Devlin
On 2017/05/23 16:51:36, Ramin Halavati wrote: > On 2017/05/23 16:48:32, Devlin (catching up) wrote: > ...
3 years, 7 months ago (2017-05-23 16:52:28 UTC) #6
Ramin Halavati
On 2017/05/23 16:52:28, Devlin (catching up) wrote: > On 2017/05/23 16:51:36, Ramin Halavati wrote: > ...
3 years, 7 months ago (2017-05-23 16:53:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900953002/1
3 years, 7 months ago (2017-05-23 16:54:44 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:42:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23912c2c5b51036910859aa8db07...

Powered by Google App Engine
This is Rietveld 408576698