Create a FakeTetherService, which stubs out TetherService for development.
This change incidentally also restarts Tether after a Chrome crash, which was overlooked previously.
Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService and create N fake Tether networks. Be sure to also pass --enable-tether, and enable Bluetooth.
BUG=672263
Review-Url: https://codereview.chromium.org/2900903002
Cr-Commit-Position: refs/heads/master@{#474555}
Committed: https://chromium.googlesource.com/chromium/src/+/035b78d057539f9542f9962411108fce5e2085ba
Description was changed from ========== Create a FakeTetherService, which stubs out TetherService for development. BUG=672263 ...
3 years, 7 months ago
(2017-05-23 00:02:56 UTC)
#1
Description was changed from
==========
Create a FakeTetherService, which stubs out TetherService for development.
BUG=672263
==========
to
==========
Create a FakeTetherService, which stubs out TetherService for development.
BUG=672263
==========
Description was changed from ========== Create a FakeTetherService, which stubs out TetherService for development. BUG=672263 ...
3 years, 7 months ago
(2017-05-23 00:04:22 UTC)
#3
Description was changed from
==========
Create a FakeTetherService, which stubs out TetherService for development.
BUG=672263
==========
to
==========
Create a FakeTetherService, which stubs out TetherService for development.
This change incidentally also restarts Tether after a Chrome crash, which was
overlooked previously.
Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService
and create N fake Tether networks.
BUG=672263
==========
Ryan Hansberry
3 years, 7 months ago
(2017-05-23 00:04:43 UTC)
#4
Ryan Hansberry
Description was changed from ========== Create a FakeTetherService, which stubs out TetherService for development. This ...
3 years, 7 months ago
(2017-05-23 00:07:44 UTC)
#5
Description was changed from
==========
Create a FakeTetherService, which stubs out TetherService for development.
This change incidentally also restarts Tether after a Chrome crash, which was
overlooked previously.
Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService
and create N fake Tether networks.
BUG=672263
==========
to
==========
Create a FakeTetherService, which stubs out TetherService for development.
This change incidentally also restarts Tether after a Chrome crash, which was
overlooked previously.
Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService
and create N fake Tether networks. Be sure to also pass --enable-tether, and
enable Bluetooth.
BUG=672263
==========
lgtm https://codereview.chromium.org/2900903002/diff/40001/chrome/browser/chromeos/tether/tether_service_factory.cc File chrome/browser/chromeos/tether/tether_service_factory.cc (right): https://codereview.chromium.org/2900903002/diff/40001/chrome/browser/chromeos/tether/tether_service_factory.cc#newcode61 chrome/browser/chromeos/tether/tether_service_factory.cc:61: fake_tether_service->set_num_tether_networks(num_tether_networks); Please make sure that setting this to ...
3 years, 7 months ago
(2017-05-23 23:17:33 UTC)
#8
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/391455)
3 years, 7 months ago
(2017-05-24 00:31:59 UTC)
#13
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/433927)
3 years, 7 months ago
(2017-05-24 19:23:23 UTC)
#18
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495676109326480, "parent_rev": "ee2e26b4a2399340086d0295e9bb6d8eee6a9507", "commit_rev": "035b78d057539f9542f9962411108fce5e2085ba"}
3 years, 7 months ago
(2017-05-25 04:53:31 UTC)
#22
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495676109326480,
"parent_rev": "ee2e26b4a2399340086d0295e9bb6d8eee6a9507", "commit_rev":
"035b78d057539f9542f9962411108fce5e2085ba"}
commit-bot: I haz the power
Description was changed from ========== Create a FakeTetherService, which stubs out TetherService for development. This ...
3 years, 7 months ago
(2017-05-25 04:53:42 UTC)
#23
Message was sent while issue was closed.
Description was changed from
==========
Create a FakeTetherService, which stubs out TetherService for development.
This change incidentally also restarts Tether after a Chrome crash, which was
overlooked previously.
Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService
and create N fake Tether networks. Be sure to also pass --enable-tether, and
enable Bluetooth.
BUG=672263
==========
to
==========
Create a FakeTetherService, which stubs out TetherService for development.
This change incidentally also restarts Tether after a Chrome crash, which was
overlooked previously.
Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService
and create N fake Tether networks. Be sure to also pass --enable-tether, and
enable Bluetooth.
BUG=672263
Review-Url: https://codereview.chromium.org/2900903002
Cr-Commit-Position: refs/heads/master@{#474555}
Committed:
https://chromium.googlesource.com/chromium/src/+/035b78d057539f9542f996241110...
==========
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/035b78d057539f9542f9962411108fce5e2085ba
3 years, 7 months ago
(2017-05-25 04:53:43 UTC)
#24
Issue 2900903002: Create a FakeTetherService, which stubs out TetherService for development.
(Closed)
Created 3 years, 7 months ago by Ryan Hansberry
Modified 3 years, 7 months ago
Reviewers: stevenjb
Base URL:
Comments: 12