Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2900903002: Create a FakeTetherService, which stubs out TetherService for development. (Closed)

Created:
3 years, 7 months ago by Ryan Hansberry
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, lesliewatkins, Jeremy Klein, James Hawkins, Kyle Horimoto
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a FakeTetherService, which stubs out TetherService for development. This change incidentally also restarts Tether after a Chrome crash, which was overlooked previously. Usage: pass --tether-stub=N as a runtime argument to enable FakeTetherService and create N fake Tether networks. Be sure to also pass --enable-tether, and enable Bluetooth. BUG=672263 Review-Url: https://codereview.chromium.org/2900903002 Cr-Commit-Position: refs/heads/master@{#474555} Committed: https://chromium.googlesource.com/chromium/src/+/035b78d057539f9542f9962411108fce5e2085ba

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 10

Patch Set 3 : stevenjb@ comments. #

Total comments: 2

Patch Set 4 : Fix failing interactive_ui_tests. #

Patch Set 5 : Put all of Tether behind a flag. TetherService was incorrectly being initialized even without the T… #

Patch Set 6 : Fix TetherService tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -36 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/chrome_session_manager.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/tether/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/tether/fake_tether_service.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/tether/fake_tether_service.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/tether/tether_service.h View 1 2 3 4 5 3 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/tether/tether_service.cc View 1 2 3 4 5 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/tether/tether_service_factory.cc View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/tether/tether_service_unittest.cc View 1 2 3 4 5 2 chunks +9 lines, -11 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Ryan Hansberry
3 years, 7 months ago (2017-05-23 00:04:43 UTC) #4
stevenjb
https://codereview.chromium.org/2900903002/diff/20001/chrome/browser/chromeos/tether/fake_tether_service.cc File chrome/browser/chromeos/tether/fake_tether_service.cc (right): https://codereview.chromium.org/2900903002/diff/20001/chrome/browser/chromeos/tether/fake_tether_service.cc#newcode9 chrome/browser/chromeos/tether/fake_tether_service.cc:9: constexpr char kCarrier[] = "Carrier"; nit: FakeCarrier https://codereview.chromium.org/2900903002/diff/20001/chrome/browser/chromeos/tether/fake_tether_service.cc#newcode34 chrome/browser/chromeos/tether/fake_tether_service.cc:34: ...
3 years, 7 months ago (2017-05-23 22:24:33 UTC) #6
Ryan Hansberry
https://codereview.chromium.org/2900903002/diff/20001/chrome/browser/chromeos/tether/fake_tether_service.cc File chrome/browser/chromeos/tether/fake_tether_service.cc (right): https://codereview.chromium.org/2900903002/diff/20001/chrome/browser/chromeos/tether/fake_tether_service.cc#newcode9 chrome/browser/chromeos/tether/fake_tether_service.cc:9: constexpr char kCarrier[] = "Carrier"; On 2017/05/23 22:24:33, stevenjb ...
3 years, 7 months ago (2017-05-23 22:53:12 UTC) #7
stevenjb
lgtm https://codereview.chromium.org/2900903002/diff/40001/chrome/browser/chromeos/tether/tether_service_factory.cc File chrome/browser/chromeos/tether/tether_service_factory.cc (right): https://codereview.chromium.org/2900903002/diff/40001/chrome/browser/chromeos/tether/tether_service_factory.cc#newcode61 chrome/browser/chromeos/tether/tether_service_factory.cc:61: fake_tether_service->set_num_tether_networks(num_tether_networks); Please make sure that setting this to ...
3 years, 7 months ago (2017-05-23 23:17:33 UTC) #8
Ryan Hansberry
https://codereview.chromium.org/2900903002/diff/40001/chrome/browser/chromeos/tether/tether_service_factory.cc File chrome/browser/chromeos/tether/tether_service_factory.cc (right): https://codereview.chromium.org/2900903002/diff/40001/chrome/browser/chromeos/tether/tether_service_factory.cc#newcode61 chrome/browser/chromeos/tether/tether_service_factory.cc:61: fake_tether_service->set_num_tether_networks(num_tether_networks); On 2017/05/23 23:17:33, stevenjb wrote: > Please make ...
3 years, 7 months ago (2017-05-23 23:24:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900903002/40001
3 years, 7 months ago (2017-05-23 23:26:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/391455)
3 years, 7 months ago (2017-05-24 00:31:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900903002/60001
3 years, 7 months ago (2017-05-24 17:33:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/433927)
3 years, 7 months ago (2017-05-24 19:23:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900903002/100001
3 years, 7 months ago (2017-05-25 01:36:22 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 04:53:43 UTC) #24
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/035b78d057539f9542f996241110...

Powered by Google App Engine
This is Rietveld 408576698