Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2900893003: Don't store raw pointers in BrowserAccessibilityManager::tree_changes_ (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't store raw pointers in BrowserAccessibilityManager::tree_changes_ Use ids instead in case objects disappear before we have a chance to fire the events. BUG=725203 Review-Url: https://codereview.chromium.org/2900893003 Cr-Commit-Position: refs/heads/master@{#473909} Committed: https://chromium.googlesource.com/chromium/src/+/6c7f50d43e10b5d4c80e4684872b732931eefccf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dmazzoni
3 years, 7 months ago (2017-05-22 23:08:45 UTC) #4
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-05-23 13:44:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900893003/1
3 years, 7 months ago (2017-05-23 15:32:20 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 15:37:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c7f50d43e10b5d4c80e4684872b...

Powered by Google App Engine
This is Rietveld 408576698