Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2900863002: IndexedDB: Restore access checks in inspector-only IDBFactory methods (Closed)

Created:
3 years, 7 months ago by jsbell
Modified:
3 years, 7 months ago
Reviewers:
dmurph
CC:
chromium-reviews, haraken, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Restore access checks in inspector-only IDBFactory methods Speculative fix for "bad message" crash that started with removal of these checks. This is a partial revert of https://codereview.chromium.org/2818173003 BUG=724868 R=dmurph@chromium.org Review-Url: https://codereview.chromium.org/2900863002 Cr-Commit-Position: refs/heads/master@{#473727} Committed: https://chromium.googlesource.com/chromium/src/+/29035633ff21733359d2c81106aa8ef0b6cf77a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 3 chunks +40 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jsbell
dmurph@ - please take a look? I decided to play it safe and revert all ...
3 years, 7 months ago (2017-05-22 19:27:59 UTC) #3
dmurph
lgtm
3 years, 7 months ago (2017-05-22 19:35:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900863002/1
3 years, 7 months ago (2017-05-22 22:19:18 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 22:25:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29035633ff21733359d2c81106aa...

Powered by Google App Engine
This is Rietveld 408576698