Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Issue 2900853002: [ObjC ARC] Converts ios/chrome/browser/physical_web:physical_web to ARC. (Closed)

Created:
3 years, 7 months ago by lindsayw
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/physical_web:physical_web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2900853002 Cr-Commit-Position: refs/heads/master@{#476618} Committed: https://chromium.googlesource.com/chromium/src/+/126df7069330e068318816b44416f10f8ca67b4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M ios/chrome/browser/physical_web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/physical_web/create_physical_web_data_source.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm View 5 chunks +19 lines, -17 lines 0 comments Download
M ios/chrome/browser/physical_web/start_physical_web_discovery.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (31 generated)
lindsayw
Hi Stepan, Thanks for the review! @mattreynolds fyi
3 years, 7 months ago (2017-05-25 19:25:43 UTC) #18
stkhapugin
lgtm
3 years, 6 months ago (2017-05-30 17:12:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900853002/1
3 years, 6 months ago (2017-05-30 17:25:58 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/450874)
3 years, 6 months ago (2017-05-30 17:35:03 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900853002/1
3 years, 6 months ago (2017-06-01 14:56:07 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/453246)
3 years, 6 months ago (2017-06-01 15:04:50 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900853002/1
3 years, 6 months ago (2017-06-01 16:23:50 UTC) #31
commit-bot: I haz the power
CQ cannot get SignCLA result. Please try later.
3 years, 6 months ago (2017-06-01 16:23:56 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900853002/1
3 years, 6 months ago (2017-06-01 16:27:33 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/453340)
3 years, 6 months ago (2017-06-01 16:36:02 UTC) #37
lindsayw
marq@chromium.org: Hi Marc can you please review as OWNER?
3 years, 6 months ago (2017-06-01 18:46:03 UTC) #39
marq (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-02 08:26:42 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900853002/1
3 years, 6 months ago (2017-06-02 11:56:05 UTC) #42
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 12:01:05 UTC) #45
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/126df7069330e068318816b44416...

Powered by Google App Engine
This is Rietveld 408576698