Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: sdk/BUILD.gn

Issue 2900833002: Properly link building dev compiler tools to create_full_sdk. (Closed)
Patch Set: Link building dev compiler tools to create_full_sdk. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/BUILD.gn
diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
index fa5f73ead95bbe7e774739d74716c8c8f1c653a4..9422455d544b55cccea1f08dbdb7564503e22e94 100644
--- a/sdk/BUILD.gn
+++ b/sdk/BUILD.gn
@@ -20,7 +20,10 @@ declare_args() {
dart_platform_sdk = false
}
-if (is_fuchsia || is_fuchsia_host) {
+if (is_fuchsia ||
+ is_fuchsia_host ||
+ current_cpu == "arm64" ||
+ current_cpu == "arm") {
dart_platform_sdk = true
}
@@ -711,11 +714,12 @@ group("create_platform_sdk") {
# Parts specific to the full SDK.
group("create_full_sdk") {
visibility = [
- ":copy_dev_compiler_tools",
":create_sdk",
]
+
deps = [
":copy_dev_compiler_sdk",
+ ":copy_dev_compiler_tools",
zra 2017/05/22 20:14:41 I'd rather have this be a dependency of copy_dev_c
Jacob 2017/05/22 20:51:13 That is better. Done.
":copy_full_sdk_libraries",
":copy_full_sdk_scripts",
":copy_full_sdk_snapshots",
@@ -737,7 +741,6 @@ group("create_sdk") {
# This rule copies tools to go along with ddc.
copy("copy_dev_compiler_tools") {
zra 2017/05/22 20:14:41 Then we can move this up above copy_dev_compiler_s
Jacob 2017/05/22 20:51:13 Done.
deps = [
- ":create_full_sdk",
"../utils/dartdevc:dartdevc_web",
"../utils/dartdevc:stack_trace_mapper",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698