Properly link building dev compiler tools to create_full_sdk.

sdk/BUILD.gn

 # Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # This GN file contains build rules for assembling the Dart SDK. There are
 # two possible variants: the "Full" SDK, and the "Platform" SDK. If you want
 # to make a new subset of the Full SDK, make it the same way we make
 # the Platform SDK.
 #
 # Warning:
 # If you need to copy something into dart-sdk/lib/foo in addition to the stuff
 # copied there by :copy_libraries, then you must depend on ":copy_libraries",
 # or ":copy_libraries" may delete/overwrite your addition, and the build will
 # fail.
 
 import("../build/copy_tree.gni")
 
 declare_args() {
   # Build a SDK with less stuff. It excludes dart2js, ddc, and web libraries.
   dart_platform_sdk = false
 }
 
-if (is_fuchsia || is_fuchsia_host) {
+if (is_fuchsia ||
+    is_fuchsia_host ||
+    current_cpu == "arm64" ||
+    current_cpu == "arm") {
   dart_platform_sdk = true
 }
 
 # The directory layout of the SDK is as follows:
 #
 # ..dart-sdk/
 # ....bin/
 # ......dart or dart.exe (executable)
 # ......dart.lib (import library for VM native extensions on Windows)
 # ......dartdoc
@@ skipping 670 matching lines @@
   deps = [
     ":copy_platform_sdk_libraries",
     ":copy_platform_sdk_scripts",
     ":copy_platform_sdk_snapshots",
   ]
 }
 
 # Parts specific to the full SDK.
 group("create_full_sdk") {
   visibility = [
-    ":copy_dev_compiler_tools",
     ":create_sdk",
   ]
+
   deps = [
     ":copy_dev_compiler_sdk",
+    ":copy_dev_compiler_tools",

[zra, 2017/05/22 20:14:41]

I'd rather have this be a dependency of copy_dev_compiler_sdk.

[Jacob, 2017/05/22 20:51:13]

That is better. Done.

     ":copy_full_sdk_libraries",
     ":copy_full_sdk_scripts",
     ":copy_full_sdk_snapshots",
   ]
 }
 
 # The main target to depend on from ../BUILD.gn
 group("create_sdk") {
   deps = [
     ":create_common_sdk",
   ]
   if (dart_platform_sdk) {
     deps += [ ":create_platform_sdk" ]
   } else {
     deps += [ ":create_full_sdk" ]
   }
 }
 
 # This rule copies tools to go along with ddc.
 copy("copy_dev_compiler_tools") {

[zra, 2017/05/22 20:14:41]

Then we can move this up above copy_dev_compiler_sdk, so that create_sdk is on
the bottom again, and these things are sort of topologically sorted.

[Jacob, 2017/05/22 20:51:13]

Done.

   deps = [
-    ":create_full_sdk",
     "../utils/dartdevc:dartdevc_web",
     "../utils/dartdevc:stack_trace_mapper",
   ]
   dart_out = get_label_info("../utils/dartdevc:dartdevc_web", "root_out_dir")
   sources = [
     "$dart_out/dev_compiler/build/web/dart_stack_trace_mapper.js",
     "$dart_out/dev_compiler/build/web/ddc_web_compiler.js",
   ]
   outputs = [
     "$root_out_dir/dart-sdk/lib/dev_compiler/web/{{source_file_part}}",
   ]
 }