Properly link building dev compiler tools to create_full_sdk.

Properly link building dev compiler tools to create_full_sdk.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/a0414390f9652e2b7cd212a0d1501c529946e344

[Jacob, 2017-05-22 20:05:16]

jacobr@google.com changed reviewers:
+ zra@google.com

[zra, 2017-05-22 20:14:41]

https://codereview.chromium.org/2900833002/diff/20001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2900833002/diff/20001/sdk/BUILD.gn#newcode722
sdk/BUILD.gn:722: ":copy_dev_compiler_tools",
I'd rather have this be a dependency of copy_dev_compiler_sdk.

https://codereview.chromium.org/2900833002/diff/20001/sdk/BUILD.gn#newcode742
sdk/BUILD.gn:742: copy("copy_dev_compiler_tools") {
Then we can move this up above copy_dev_compiler_sdk, so that create_sdk is on
the bottom again, and these things are sort of topologically sorted.

[Jacob, 2017-05-22 20:51:13]

https://codereview.chromium.org/2900833002/diff/20001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2900833002/diff/20001/sdk/BUILD.gn#newcode722
sdk/BUILD.gn:722: ":copy_dev_compiler_tools",
On 2017/05/22 20:14:41, zra wrote:
> I'd rather have this be a dependency of copy_dev_compiler_sdk.

That is better. Done.

https://codereview.chromium.org/2900833002/diff/20001/sdk/BUILD.gn#newcode742
sdk/BUILD.gn:742: copy("copy_dev_compiler_tools") {
On 2017/05/22 20:14:41, zra wrote:
> Then we can move this up above copy_dev_compiler_sdk, so that create_sdk is on
> the bottom again, and these things are sort of topologically sorted.

Done.

[zra, 2017-05-22 20:56:10]

https://codereview.chromium.org/2900833002/diff/40001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2900833002/diff/40001/sdk/BUILD.gn#newcode488
sdk/BUILD.gn:488: deps = [
This also needs to depend on ":copy_dev_compiler_js" otherwise the copy_tree()
rule can clobber the copies done by this rule.

[Jacob, 2017-05-22 21:29:02]

https://codereview.chromium.org/2900833002/diff/40001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2900833002/diff/40001/sdk/BUILD.gn#newcode488
sdk/BUILD.gn:488: deps = [
On 2017/05/22 20:56:09, zra wrote:
> This also needs to depend on ":copy_dev_compiler_js" otherwise the copy_tree()
> rule can clobber the copies done by this rule.

Done.

[zra, 2017-05-22 21:34:45]

https://codereview.chromium.org/2900833002/diff/60001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2900833002/diff/60001/sdk/BUILD.gn#newcode465
sdk/BUILD.gn:465: ":copy_dev_compiler_require_js",
Hmm. I was expecting that you'd have to add ":copy_dev_compiler_tools" here.

[Jacob, 2017-05-22 21:49:31]

https://codereview.chromium.org/2900833002/diff/60001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2900833002/diff/60001/sdk/BUILD.gn#newcode465
sdk/BUILD.gn:465: ":copy_dev_compiler_require_js",
On 2017/05/22 21:34:45, zra wrote:
> Hmm. I was expecting that you'd have to add ":copy_dev_compiler_tools" here.

Done.

[zra, 2017-05-22 21:50:19]

lgtm

[Jacob, 2017-05-24 17:00:07]

Description was changed from

==========
Properly link building dev compiler tools to create_full_sdk.

BUG=
==========

to

==========
Properly link building dev compiler tools to create_full_sdk.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a0414390f9652e2b7cd212a0d1501c529946e344
==========

[Jacob, 2017-05-24 17:00:10]

Committed patchset #5 (id:30002) manually as
a0414390f9652e2b7cd212a0d1501c529946e344 (presubmit successful).