base/prefs/pref_notifier_impl.h - Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_notifier_impl.h

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compilation Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/prefs/pref_notifier_impl.h

diff --git a/base/prefs/pref_notifier_impl.h b/base/prefs/pref_notifier_impl.h

index 655203d06dbc767bdbff76bb569ebe8380a82f95..9e859cab715bab16a7dde0fe3e190bede6fdbfd8 100644

--- a/base/prefs/pref_notifier_impl.h

+++ b/base/prefs/pref_notifier_impl.h

@@ -43,6 +43,9 @@ class BASE_PREFS_EXPORT PrefNotifierImpl

// PrefNotifier overrides.

virtual void OnPreferenceChanged(const std::string& pref_name) OVERRIDE;

virtual void OnInitializationCompleted(bool succeeded) OVERRIDE;

+ // TODO(battre): Delete this. See crbug.com/373435.

+ virtual void BroadcastPrefServiceDestructionTrace(

+ const std::string& stack_trace) OVERRIDE;

// A map from pref names to a list of observers. Observers get fired in the

// order they are added. These should only be accessed externally for unit

« no previous file with comments | « base/prefs/pref_notifier.h ('k') | base/prefs/pref_notifier_impl.cc » ('j') | no next file with comments »