Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: base/prefs/pref_notifier_impl.cc

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compilation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/pref_notifier_impl.h ('k') | base/prefs/pref_notifier_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_notifier_impl.cc
diff --git a/base/prefs/pref_notifier_impl.cc b/base/prefs/pref_notifier_impl.cc
index c02a7b3f5a5bfd8d4bd5c56ce20ca699e6d10346..ff5603c5d08a8bd5303a31f2568e5d3ce4f951ef 100644
--- a/base/prefs/pref_notifier_impl.cc
+++ b/base/prefs/pref_notifier_impl.cc
@@ -94,6 +94,19 @@ void PrefNotifierImpl::OnInitializationCompleted(bool succeeded) {
}
}
+// TODO(battre): Delete this. See crbug.com/373435.
+void PrefNotifierImpl::BroadcastPrefServiceDestructionTrace(
+ const std::string& stack_trace) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ for (PrefObserverMap::iterator observer_iterator = pref_observers_.begin();
+ observer_iterator != pref_observers_.end();
+ ++observer_iterator) {
+ FOR_EACH_OBSERVER(PrefObserver,
+ *(observer_iterator->second),
+ SetPrefServiceDestructionTrace(stack_trace));
+ }
+}
+
void PrefNotifierImpl::FireObservers(const std::string& path) {
DCHECK(thread_checker_.CalledOnValidThread());
« no previous file with comments | « base/prefs/pref_notifier_impl.h ('k') | base/prefs/pref_notifier_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698