Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2900803003: Automation API hit test should automatically convert to integer coordinates. (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
aleventhal, aboxhall
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Automation API hit test should automatically convert to integer coordinates. The automation API specifies the hit test coordinates should be integers which is fine since there's no reason for sub-pixel precision. However, it crashes if you pass it a non-integer, which is not good! It should just convert to an integer. BUG=725159 TBR=aboxhall Review-Url: https://codereview.chromium.org/2900803003 Cr-Commit-Position: refs/heads/master@{#473960} Committed: https://chromium.googlesource.com/chromium/src/+/c2dc689ce3df14d3fa613cc22c3f132c7eba4463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/sites/hit_test.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/hit_test.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dmazzoni
3 years, 7 months ago (2017-05-22 18:35:33 UTC) #2
aleventhal
lgtm
3 years, 7 months ago (2017-05-22 19:21:40 UTC) #3
dmazzoni
(Alice, can you rubberstamp this?)
3 years, 7 months ago (2017-05-23 16:07:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900803003/1
3 years, 7 months ago (2017-05-23 16:08:07 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:36:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2dc689ce3df14d3fa613cc22c3f...

Powered by Google App Engine
This is Rietveld 408576698