Renaming zip_analyzer_results to archive_analyzer_results

Also moved archive_analyzer_results into the safebrowsing namespace.

BUG=722461
Review-Url: https://codereview.chromium.org/2900803002
Cr-Commit-Position: refs/heads/master@{#474102}
Committed: https://chromium.googlesource.com/chromium/src/+/099f5b20a46bc52066e9cbd2167d7747e59984cd

[mortonm, 2017-05-22 21:46:39]

Description was changed from

==========
starting to refactor archive analyzer code


starting to refactor archive analyzer code

BUG=722461
==========

to

==========
Also moved the archive_analyzer_results struct into the safebrowsing namespace.

BUG=722461
==========

[mortonm, 2017-05-22 22:19:19]

Description was changed from

==========
Also moved the archive_analyzer_results struct into the safebrowsing namespace.

BUG=722461
==========

to

==========
Also moved archive_analyzer_results into the safebrowsing namespace.

BUG=722461
==========

[mortonm, 2017-05-22 22:22:21]

mortonm@google.com changed reviewers:
+ jialiul@chromium.org

[Jialiu Lin, 2017-05-22 22:23:12]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:23:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:54:10]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2017-05-23 02:12:05]

Almost there. 2 nits.

https://codereview.chromium.org/2900803002/diff/140001/chrome/common/safe_bro...
File chrome/common/safe_browsing/archive_analyzer_results.h (right):

https://codereview.chromium.org/2900803002/diff/140001/chrome/common/safe_bro...
chrome/common/safe_browsing/archive_analyzer_results.h:8: #ifndef
CHROME_COMMON_SAFE_BROWSING_ZIP_ANALYZER_RESULTS_H_
update #ifndef and #define as well.

https://codereview.chromium.org/2900803002/diff/140001/chrome/common/safe_bro...
chrome/common/safe_browsing/archive_analyzer_results.h:32: #endif  //
CHROME_COMMON_SAFE_BROWSING_ZIP_ANALYZER_RESULTS_H_
And the comment

[mortonm, 2017-05-23 16:29:43]

https://codereview.chromium.org/2900803002/diff/140001/chrome/common/safe_bro...
File chrome/common/safe_browsing/archive_analyzer_results.h (right):

https://codereview.chromium.org/2900803002/diff/140001/chrome/common/safe_bro...
chrome/common/safe_browsing/archive_analyzer_results.h:8: #ifndef
CHROME_COMMON_SAFE_BROWSING_ZIP_ANALYZER_RESULTS_H_
On 2017/05/23 02:12:05, Jialiu Lin wrote:
> update #ifndef and #define as well.

Done.

https://codereview.chromium.org/2900803002/diff/140001/chrome/common/safe_bro...
chrome/common/safe_browsing/archive_analyzer_results.h:32: #endif  //
CHROME_COMMON_SAFE_BROWSING_ZIP_ANALYZER_RESULTS_H_
On 2017/05/23 02:12:05, Jialiu Lin wrote:
> And the comment

Done.

[vakh (use Gerrit instead), 2017-05-23 17:34:29]

vakh@chromium.org changed reviewers:
+ vakh@chromium.org

[vakh (use Gerrit instead), 2017-05-23 17:34:31]

lgtm

https://codereview.chromium.org/2900803002/diff/160001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/download_protection_service.cc (left):

https://codereview.chromium.org/2900803002/diff/160001/chrome/browser/safe_br...
chrome/browser/safe_browsing/download_protection_service.cc:51: #include
"chrome/common/safe_browsing/zip_analyzer_results.h"
Please #include the new file.
You don't want to depend on indirect includes.

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
File chrome/common/safe_browsing/archive_analyzer_results.cc (right):

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
chrome/common/safe_browsing/archive_analyzer_results.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
copyright year.

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
File chrome/common/safe_browsing/zip_analyzer_results.cc (left):

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
chrome/common/safe_browsing/zip_analyzer_results.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
Diff may be showing me something wrong here but it looks like the file is being
emptied out, not deleted. Is that intentional?

https://codereview.chromium.org/2900803002/diff/160001/chrome/utility/safe_br...
File chrome/utility/safe_browsing/mac/dmg_analyzer.h (right):

https://codereview.chromium.org/2900803002/diff/160001/chrome/utility/safe_br...
chrome/utility/safe_browsing/mac/dmg_analyzer.h:14: // Analyzes a DMG file and
reports the results.
Optional: Comment does not add any information that the declaration doesn't
already provide. Please consider removing the comment.

[Jialiu Lin, 2017-05-23 17:42:02]

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
File chrome/common/safe_browsing/zip_analyzer_results.cc (left):

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
chrome/common/safe_browsing/zip_analyzer_results.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2017/05/23 17:34:30, vakh (Varun Khaneja) wrote:
> Diff may be showing me something wrong here but it looks like the file is
being
> emptied out, not deleted. Is that intentional?

I patched this CL yesterday and this file was correctly deteleted. Not sure why
it shows up on code review as 'M' instead of 'D'.

[Jialiu Lin, 2017-05-23 17:48:56]

LGTM after addressing vakh's comments

[mortonm, 2017-05-23 17:53:52]

https://codereview.chromium.org/2900803002/diff/160001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/download_protection_service.cc (left):

https://codereview.chromium.org/2900803002/diff/160001/chrome/browser/safe_br...
chrome/browser/safe_browsing/download_protection_service.cc:51: #include
"chrome/common/safe_browsing/zip_analyzer_results.h"
On 2017/05/23 17:34:30, vakh (Varun Khaneja) wrote:
> Please #include the new file.
> You don't want to depend on indirect includes.

Done.

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
File chrome/common/safe_browsing/archive_analyzer_results.cc (right):

https://codereview.chromium.org/2900803002/diff/160001/chrome/common/safe_bro...
chrome/common/safe_browsing/archive_analyzer_results.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2017/05/23 17:34:31, vakh (Varun Khaneja) wrote:
> copyright year.

Done.

https://codereview.chromium.org/2900803002/diff/160001/chrome/utility/safe_br...
File chrome/utility/safe_browsing/mac/dmg_analyzer.h (right):

https://codereview.chromium.org/2900803002/diff/160001/chrome/utility/safe_br...
chrome/utility/safe_browsing/mac/dmg_analyzer.h:14: // Analyzes a DMG file and
reports the results.
On 2017/05/23 17:34:31, vakh (Varun Khaneja) wrote:
> Optional: Comment does not add any information that the declaration doesn't
> already provide. Please consider removing the comment.

Done.

[mortonm, 2017-05-23 18:10:04]

The CQ bit was checked by mortonm@google.com

[mortonm, 2017-05-23 18:10:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vakh@chromium.org,
jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2900803002/#ps180001
(title: "minor fixups")

[commit-bot: I haz the power, 2017-05-23 18:11:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:21:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:21:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mortonm, 2017-05-23 18:38:58]

mortonm@google.com changed reviewers:
+ dcheng@chromium.org, sky@chromium.org

[mortonm, 2017-05-23 18:38:59]

+ sky@ and dcheng@ for owner review: 

    chrome/common/chrome_utility_messages.h
    chrome/common/safe_archive_analyzer.typemap
    chrome/utility/chrome_content_utility_client.cc

No logic changes, just changing structure.

[sky, 2017-05-23 23:10:29]

LGTM

[dcheng, 2017-05-23 23:16:03]

rs lgtm for ipc

[mortonm, 2017-05-23 23:20:33]

The CQ bit was checked by mortonm@google.com

[commit-bot: I haz the power, 2017-05-23 23:22:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:31:52]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495581633664890,
"parent_rev": "dedb25685f8838221a1b68034d91460c32fd0467", "commit_rev":
"099f5b20a46bc52066e9cbd2167d7747e59984cd"}

[commit-bot: I haz the power, 2017-05-23 23:32:14]

Description was changed from

==========
Also moved archive_analyzer_results into the safebrowsing namespace.

BUG=722461
==========

to

==========
Also moved archive_analyzer_results into the safebrowsing namespace.

BUG=722461

Review-Url: https://codereview.chromium.org/2900803002
Cr-Commit-Position: refs/heads/master@{#474102}
Committed:
https://chromium.googlesource.com/chromium/src/+/099f5b20a46bc52066e9cbd2167d...
==========

[commit-bot: I haz the power, 2017-05-23 23:32:16]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/099f5b20a46bc52066e9cbd2167d...