[Android WebView] include CrashDumpManager java-side.

[Android WebView] include CrashDumpManager java-side.

The content/browser/crash/ component calls into the java-side of
CrashDumpManager from
components/crash/content/browser/crash_dump_manager_android.cc, since
WebView doesn't include that java file it throws an exception at that
point.
This CL Includes the content/browser/crash/ component into Android
WebView.

BUG=725207
Review-Url: https://codereview.chromium.org/2900793003
Cr-Commit-Position: refs/heads/master@{#473869}
Committed: https://chromium.googlesource.com/chromium/src/+/ef6ff00396eb81157f1c7c4992a1bdcc8eba8113

[gsennton, 2017-05-22 20:31:24]

gsennton@chromium.org changed reviewers:
+ isherman@chromium.org, tobiasjs@chromium.org

[gsennton, 2017-05-22 20:31:24]

Hi, Ilya, do you think we should solve the bug this way, or explicitly make sure
that we never call into the Java-side from WebView somehow?

[Ilya Sherman, 2017-05-22 20:34:24]

LGTM, thanks Gustav.

On 2017/05/22 20:31:24, gsennton wrote:
> Hi, Ilya, do you think we should solve the bug this way, or explicitly make
sure
> that we never call into the Java-side from WebView somehow?

I think this solution is fine.  We could instead not call the code on WebView --
that seems a bit messier to me, but I'd also be ok with that if you prefer.

[Tobias Sargeant, 2017-05-23 11:08:46]

On 2017/05/22 20:31:24, gsennton wrote:
> Hi, Ilya, do you think we should solve the bug this way, or explicitly make
sure
> that we never call into the Java-side from WebView somehow?

LGTM. Monochrome makes it impossible to make a compile-time distinction between
clank and webview, so I think it's right to include this for that reason.
However it seems like the fact that we will now log a message for every renderer
crash is subpotimal. Could someone please address that?

[gsennton, 2017-05-23 11:23:48]

On 2017/05/23 11:08:46, Tobias Sargeant wrote:
> On 2017/05/22 20:31:24, gsennton wrote:
> > Hi, Ilya, do you think we should solve the bug this way, or explicitly make
> sure
> > that we never call into the Java-side from WebView somehow?
> 
> LGTM. Monochrome makes it impossible to make a compile-time distinction
between
> clank and webview, so I think it's right to include this for that reason.
> However it seems like the fact that we will now log a message for every
renderer
> crash is subpotimal. Could someone please address that?

Thanks, filed crbug.com/725449

[gsennton, 2017-05-23 11:23:53]

The CQ bit was checked by gsennton@chromium.org

[commit-bot: I haz the power, 2017-05-23 11:24:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 12:46:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495538633357280, "parent_rev":
"50dd2bde25f729081248de4c835d1ef99c695754", "commit_rev":
"ef6ff00396eb81157f1c7c4992a1bdcc8eba8113"}

[commit-bot: I haz the power, 2017-05-23 12:46:41]

Description was changed from

==========
[Android WebView] include CrashDumpManager java-side.

The content/browser/crash/ component calls into the java-side of
CrashDumpManager from
components/crash/content/browser/crash_dump_manager_android.cc, since
WebView doesn't include that java file it throws an exception at that
point.
This CL Includes the content/browser/crash/ component into Android
WebView.

BUG=725207
==========

to

==========
[Android WebView] include CrashDumpManager java-side.

The content/browser/crash/ component calls into the java-side of
CrashDumpManager from
components/crash/content/browser/crash_dump_manager_android.cc, since
WebView doesn't include that java file it throws an exception at that
point.
This CL Includes the content/browser/crash/ component into Android
WebView.

BUG=725207

Review-Url: https://codereview.chromium.org/2900793003
Cr-Commit-Position: refs/heads/master@{#473869}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef6ff00396eb81157f1c7c4992a1...
==========

[commit-bot: I haz the power, 2017-05-23 12:46:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef6ff00396eb81157f1c7c4992a1...