Use SetSelection in ExecuteDeleteToMark

Use SetSelection in ExecuteDeleteToMark

ExecuteDeleteToMark function is changed to use SetSelection instead of 
SetSelectedRange.

BUG=721190
Review-Url: https://codereview.chromium.org/2900773002
Cr-Commit-Position: refs/heads/master@{#473847}
Committed: https://chromium.googlesource.com/chromium/src/+/5696d44bd68a8745a52e99d2dcac190c391eebbd

[tanvir, 2017-05-22 13:53:19]

Description was changed from

==========
Use SetSelection in ExecuteDeleteToMark and ExecuteSelectToMark

ExecuteDeleteToMark and ExecuteSelectToMark functions are
changed to use SetSelection instead of SetSelectedRange.

BUG=721190
==========

to

==========
Use SetSelection in ExecuteDeleteToMark and ExecuteSelectToMark

ExecuteDeleteToMark and ExecuteSelectToMark functions are
changed to use SetSelection instead of SetSelectedRange.

BUG=721190
==========

[tanvir, 2017-05-22 13:53:20]

tanvir.rizvi@samsung.com changed reviewers:
+ srirama.m@samsung.com, yosin@chromium.org

[tanvir, 2017-05-22 14:11:48]

PTAL!!!
Thanks

[yosin_UTC9, 2017-05-23 01:25:54]

https://codereview.chromium.org/2900773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2900773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:814: if
(mark.IsNull())
When |mark.IsNull()|, this function should do:
  frame.GetEditor().PerformDelete();
  frame.GetEditor().SetMark(
      frame.Selection().ComputeVisibleSelectionInDOMTreeDeprecated());
  return true;

https://codereview.chromium.org/2900773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1794:
frame.Selection().SetSelection(
It is better to move this change in another patch.

[tanvir, 2017-05-23 06:03:10]

PTAL! Thanks

https://codereview.chromium.org/2900773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2900773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:814: if
(mark.IsNull())
On 2017/05/23 01:25:54, yosin_UTC9 wrote:
> When |mark.IsNull()|, this function should do:
>   frame.GetEditor().PerformDelete();
>   frame.GetEditor().SetMark(
>       frame.Selection().ComputeVisibleSelectionInDOMTreeDeprecated());
>   return true;

Done.

[tanvir, 2017-05-23 06:03:54]

Description was changed from

==========
Use SetSelection in ExecuteDeleteToMark and ExecuteSelectToMark

ExecuteDeleteToMark and ExecuteSelectToMark functions are
changed to use SetSelection instead of SetSelectedRange.

BUG=721190
==========

to

==========
Use SetSelection in ExecuteDeleteToMark

ExecuteDeleteToMark function ischanged to use SetSelection instead of 
SetSelectedRange.

BUG=721190
==========

[tanvir, 2017-05-23 06:04:09]

Description was changed from

==========
Use SetSelection in ExecuteDeleteToMark

ExecuteDeleteToMark function ischanged to use SetSelection instead of 
SetSelectedRange.

BUG=721190
==========

to

==========
Use SetSelection in ExecuteDeleteToMark

ExecuteDeleteToMark function is changed to use SetSelection instead of 
SetSelectedRange.

BUG=721190
==========

[yosin_UTC9, 2017-05-23 08:37:01]

lgtm

Thanks for working this!

[yosin_UTC9, 2017-05-23 08:37:02]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:37:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tanvir, 2017-05-23 08:39:21]

On 2017/05/23 08:37:01, yosin_UTC9 wrote:
> lgtm
> 
> Thanks for working this!

Thanks.
@yosin-: Can i get the access for 'try bot' and 'edit bug'?  Thanks.

[yosin_UTC9, 2017-05-23 09:58:38]

On 2017/05/23 at 08:39:21, tanvir.rizvi wrote:
> On 2017/05/23 08:37:01, yosin_UTC9 wrote:
> > lgtm
> > 
> > Thanks for working this!
> 
> Thanks.
> @yosin-: Can i get the access for 'try bot' and 'edit bug'?  Thanks.

Here is instruction how to get privilege:
http://dev.chromium.org/getting-involved/become-a-committer

I'm happy to support you.

[commit-bot: I haz the power, 2017-05-23 10:15:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495528622720000,
"parent_rev": "e1719ffa41c44d3434095850fee7ffa5b6e57c4f", "commit_rev":
"5696d44bd68a8745a52e99d2dcac190c391eebbd"}

[commit-bot: I haz the power, 2017-05-23 10:15:59]

Description was changed from

==========
Use SetSelection in ExecuteDeleteToMark

ExecuteDeleteToMark function is changed to use SetSelection instead of 
SetSelectedRange.

BUG=721190
==========

to

==========
Use SetSelection in ExecuteDeleteToMark

ExecuteDeleteToMark function is changed to use SetSelection instead of 
SetSelectedRange.

BUG=721190

Review-Url: https://codereview.chromium.org/2900773002
Cr-Commit-Position: refs/heads/master@{#473847}
Committed:
https://chromium.googlesource.com/chromium/src/+/5696d44bd68a8745a52e99d2dcac...
==========

[commit-bot: I haz the power, 2017-05-23 10:16:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5696d44bd68a8745a52e99d2dcac...