Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: src/objects.h

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Address feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index d4f1bb4cc87681e0e3cca25151aa08c59973450e..a659ead158ec85a7729ad153089343d9764c752f 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7118,6 +7118,10 @@ class Symbol: public Name {
// [name]: The print name of a symbol, or undefined if none.
DECL_ACCESSORS(name, Object)
+ // [descriptive_string]: The descriptive string of a symbol. This is the
+ // value returned from the Symbol.prototype.toString method.
+ DECL_ACCESSORS(descriptive_string, String)
+
DECL_INT_ACCESSORS(flags)
// [is_private]: Whether this is a private symbol. Private symbols can only
@@ -7141,7 +7145,8 @@ class Symbol: public Name {
// Layout description.
static const int kNameOffset = Name::kSize;
- static const int kFlagsOffset = kNameOffset + kPointerSize;
+ static const int kDescriptiveStringOffset = kNameOffset + kPointerSize;
+ static const int kFlagsOffset = kDescriptiveStringOffset + kPointerSize;
static const int kSize = kFlagsOffset + kPointerSize;
// Flags layout.
« no previous file with comments | « src/isolate.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698