src/isolate.cc - Issue 2900703002: [es2015] Precompute the descriptive string for symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)

Patch Set: Address feedback. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index faa04848cff43c13c49ff5837ecb6718deac3822..5d4946f520c2de88a6e5fada0c66ed6ff87b91f5 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -3270,9 +3270,8 @@ Handle<Symbol> Isolate::SymbolFor(Heap::RootListIndex dictionary_index,

int entry = dictionary->FindEntry(key);

Handle<Symbol> symbol;

if (entry == NameDictionary::kNotFound) {

- symbol =

- private_symbol ? factory()->NewPrivateSymbol() : factory()->NewSymbol();

- symbol->set_name(*key);

+ symbol = private_symbol ? factory()->NewPrivateSymbol(key).ToHandleChecked()

+ : factory()->NewSymbol(key).ToHandleChecked();

dictionary = NameDictionary::Add(dictionary, key, symbol,

PropertyDetails::Empty(), &entry);

switch (dictionary_index) {

« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »