Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: src/factory.h

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Fix compile in MIPS. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/factory.h
diff --git a/src/factory.h b/src/factory.h
index 81462055593acb61d6fe66a0740a5a8b51fffacd..bb0eded55baf0ae4332d03189ef6e170748eaee4 100644
--- a/src/factory.h
+++ b/src/factory.h
@@ -267,7 +267,9 @@ class V8_EXPORT_PRIVATE Factory final {
// Create a symbol.
Handle<Symbol> NewSymbol();
Igor Sheludko 2017/05/23 07:08:23 Please move this helper method to the private sect
Benedikt Meurer 2017/05/23 08:37:39 Done.
+ MaybeHandle<Symbol> NewSymbol(Handle<Object> name);
Handle<Symbol> NewPrivateSymbol();
+ MaybeHandle<Symbol> NewPrivateSymbol(Handle<Object> name);
// Create a promise.
Handle<JSPromise> NewJSPromise();

Powered by Google App Engine
This is Rietveld 408576698