 Chromium Code Reviews
 Chromium Code Reviews Issue 2900703002:
  [es2015] Precompute the descriptive string for symbols.  (Closed)
    
  
    Issue 2900703002:
  [es2015] Precompute the descriptive string for symbols.  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright 2014 the V8 project authors. All rights reserved. | 1 // Copyright 2014 the V8 project authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef V8_FACTORY_H_ | 5 #ifndef V8_FACTORY_H_ | 
| 6 #define V8_FACTORY_H_ | 6 #define V8_FACTORY_H_ | 
| 7 | 7 | 
| 8 #include "src/feedback-vector.h" | 8 #include "src/feedback-vector.h" | 
| 9 #include "src/globals.h" | 9 #include "src/globals.h" | 
| 10 #include "src/isolate.h" | 10 #include "src/isolate.h" | 
| (...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 259 MUST_USE_RESULT MaybeHandle<String> NewExternalStringFromOneByte( | 259 MUST_USE_RESULT MaybeHandle<String> NewExternalStringFromOneByte( | 
| 260 const ExternalOneByteString::Resource* resource); | 260 const ExternalOneByteString::Resource* resource); | 
| 261 MUST_USE_RESULT MaybeHandle<String> NewExternalStringFromTwoByte( | 261 MUST_USE_RESULT MaybeHandle<String> NewExternalStringFromTwoByte( | 
| 262 const ExternalTwoByteString::Resource* resource); | 262 const ExternalTwoByteString::Resource* resource); | 
| 263 // Create a new external string object for one-byte encoded native script. | 263 // Create a new external string object for one-byte encoded native script. | 
| 264 // It does not cache the resource data pointer. | 264 // It does not cache the resource data pointer. | 
| 265 Handle<ExternalOneByteString> NewNativeSourceString( | 265 Handle<ExternalOneByteString> NewNativeSourceString( | 
| 266 const ExternalOneByteString::Resource* resource); | 266 const ExternalOneByteString::Resource* resource); | 
| 267 | 267 | 
| 268 // Create a symbol. | 268 // Create a symbol. | 
| 269 Handle<Symbol> NewSymbol(); | 269 Handle<Symbol> NewSymbol(); | 
| 
Igor Sheludko
2017/05/23 07:08:23
Please move this helper method to the private sect
 
Benedikt Meurer
2017/05/23 08:37:39
Done.
 | |
| 270 MaybeHandle<Symbol> NewSymbol(Handle<Object> name); | |
| 270 Handle<Symbol> NewPrivateSymbol(); | 271 Handle<Symbol> NewPrivateSymbol(); | 
| 272 MaybeHandle<Symbol> NewPrivateSymbol(Handle<Object> name); | |
| 271 | 273 | 
| 272 // Create a promise. | 274 // Create a promise. | 
| 273 Handle<JSPromise> NewJSPromise(); | 275 Handle<JSPromise> NewJSPromise(); | 
| 274 | 276 | 
| 275 // Create a global (but otherwise uninitialized) context. | 277 // Create a global (but otherwise uninitialized) context. | 
| 276 Handle<Context> NewNativeContext(); | 278 Handle<Context> NewNativeContext(); | 
| 277 | 279 | 
| 278 // Create a script context. | 280 // Create a script context. | 
| 279 Handle<Context> NewScriptContext(Handle<JSFunction> function, | 281 Handle<Context> NewScriptContext(Handle<JSFunction> function, | 
| 280 Handle<ScopeInfo> scope_info); | 282 Handle<ScopeInfo> scope_info); | 
| (...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 843 void SetStrictFunctionInstanceDescriptor(Handle<Map> map, | 845 void SetStrictFunctionInstanceDescriptor(Handle<Map> map, | 
| 844 FunctionMode function_mode); | 846 FunctionMode function_mode); | 
| 845 | 847 | 
| 846 void SetClassFunctionInstanceDescriptor(Handle<Map> map); | 848 void SetClassFunctionInstanceDescriptor(Handle<Map> map); | 
| 847 }; | 849 }; | 
| 848 | 850 | 
| 849 } // namespace internal | 851 } // namespace internal | 
| 850 } // namespace v8 | 852 } // namespace v8 | 
| 851 | 853 | 
| 852 #endif // V8_FACTORY_H_ | 854 #endif // V8_FACTORY_H_ | 
| OLD | NEW |