Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: ios/chrome/browser/passwords/ios_chrome_password_manager_client.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
diff --git a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
index b0cbd424ab0b7ddb6d566f3997e66b5eb1c67cfd..2e5aa6c4d9d4072db110a7f12389e3210ab93d9c 100644
--- a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
+++ b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
@@ -22,11 +22,11 @@ class PasswordFormManager;
// Shows UI to prompt the user to save the password.
- (void)showSavePasswordInfoBar:
- (std::unique_ptr<password_manager::PasswordFormManager>)formToSave;
+ (scoped_refptr<password_manager::PasswordFormManager>)formToSave;
// Shows UI to prompt the user to update the password.
- (void)showUpdatePasswordInfoBar:
- (std::unique_ptr<password_manager::PasswordFormManager>)formToUpdate;
+ (scoped_refptr<password_manager::PasswordFormManager>)formToUpdate;
@property(readonly, nonatomic) ios::ChromeBrowserState* browserState;
@@ -46,14 +46,14 @@ class IOSChromePasswordManagerClient
// password_manager::PasswordManagerClient implementation.
password_manager::PasswordSyncState GetPasswordSyncState() const override;
bool PromptUserToSaveOrUpdatePassword(
- std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
+ scoped_refptr<password_manager::PasswordFormManager> form_to_save,
bool update_password) override;
bool PromptUserToChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,
const GURL& origin,
const CredentialsCallback& callback) override;
void AutomaticPasswordSave(
- std::unique_ptr<password_manager::PasswordFormManager> saved_form_manager)
+ scoped_refptr<password_manager::PasswordFormManager> saved_form_manager)
override;
bool IsIncognito() const override;
PrefService* GetPrefs() override;

Powered by Google App Engine
This is Rietveld 408576698