Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
diff --git a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
index 2830c559af3a41c56a5023c1bca45d81c1ede17b..1ae27e47c28eee1b9dec8e4671ff91c9c5a8071f 100644
--- a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
+++ b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
@@ -96,12 +96,13 @@ class CredentialsFilterTest : public SyncUsernameTestBase {
CredentialsFilterTest()
: password_manager_(&client_),
pending_(SimpleGaiaForm("user@gmail.com")),
- form_manager_(&password_manager_,
- &client_,
- driver_.AsWeakPtr(),
- pending_,
- base::MakeUnique<StubFormSaver>(),
- &fetcher_),
+ form_manager_(base::MakeRefCounted<PasswordFormManager>(
+ &password_manager_,
+ &client_,
+ driver_.AsWeakPtr(),
+ pending_,
+ base::MakeUnique<StubFormSaver>(),
+ &fetcher_)),
filter_(&client_,
base::Bind(&SyncUsernameTestBase::sync_service,
base::Unretained(this)),
@@ -138,7 +139,7 @@ class CredentialsFilterTest : public SyncUsernameTestBase {
}
fetcher_.SetNonFederated(matches, 0u);
- form_manager_.ProvisionallySave(
+ form_manager_->ProvisionallySave(
pending_, PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
}
@@ -148,7 +149,7 @@ class CredentialsFilterTest : public SyncUsernameTestBase {
StubPasswordManagerDriver driver_;
PasswordForm pending_;
FakeFormFetcher fetcher_;
- PasswordFormManager form_manager_;
+ scoped_refptr<PasswordFormManager> form_manager_;
SyncCredentialsFilter filter_;
};
@@ -286,7 +287,7 @@ TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_ExistingSyncCredentials) {
base::UserActionTester tester;
SavePending(LoginState::EXISTING);
- filter_.ReportFormLoginSuccess(form_manager_);
+ filter_.ReportFormLoginSuccess(*form_manager_);
EXPECT_EQ(1, tester.GetActionCount(kFilledAndLoginActionName));
}
@@ -296,7 +297,7 @@ TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_NewSyncCredentials) {
base::UserActionTester tester;
SavePending(LoginState::NEW);
- filter_.ReportFormLoginSuccess(form_manager_);
+ filter_.ReportFormLoginSuccess(*form_manager_);
EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
}
@@ -308,7 +309,7 @@ TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_GAIANotSyncCredentials) {
base::UserActionTester tester;
SavePending(LoginState::EXISTING);
- filter_.ReportFormLoginSuccess(form_manager_);
+ filter_.ReportFormLoginSuccess(*form_manager_);
EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
}
@@ -319,7 +320,7 @@ TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_NotGAIACredentials) {
base::UserActionTester tester;
SavePending(LoginState::EXISTING);
- filter_.ReportFormLoginSuccess(form_manager_);
+ filter_.ReportFormLoginSuccess(*form_manager_);
EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
}
@@ -329,7 +330,7 @@ TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_NotSyncing) {
base::UserActionTester tester;
SavePending(LoginState::EXISTING);
- filter_.ReportFormLoginSuccess(form_manager_);
+ filter_.ReportFormLoginSuccess(*form_manager_);
EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
}

Powered by Google App Engine
This is Rietveld 408576698