[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

Rename TabModel ivar from webUsageEnabled_ to _webUsageEnabled
for consistency with the other ivars that use the new convention.

BUG=724282
Review-Url: https://codereview.chromium.org/2900643003
Cr-Commit-Position: refs/heads/master@{#473886}
Committed: https://chromium.googlesource.com/chromium/src/+/fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd

[sdefresne, 2017-05-22 10:17:21]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 10:17:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 10:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 10:25:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2017-05-22 12:52:36]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 12:52:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 13:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 13:06:26]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-05-22 13:58:20]

Patchset #1 (id:1) has been deleted

[sdefresne, 2017-05-22 13:58:28]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 13:58:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-05-22 13:59:52]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-05-22 14:00:03]

Patchset #1 (id:20001) has been deleted

[sdefresne, 2017-05-22 14:00:10]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 14:00:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-05-22 14:01:45]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 14:01:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-05-22 14:02:03]

Patchset #1 (id:40001) has been deleted

[sdefresne, 2017-05-22 14:03:15]

sdefresne@chromium.org changed reviewers:
+ noyau@chromium.org

[sdefresne, 2017-05-22 14:03:16]

Please take a look.

[sdefresne, 2017-05-22 14:05:33]

Description was changed from

==========
[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

BUG=724282
==========

to

==========
[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

Rename TabModel ivar from webUsageEnabled_ to _webUsageEnabled
for consistency with the other ivars that use the new convention.

BUG=724282
==========

[commit-bot: I haz the power, 2017-05-22 14:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 14:11:19]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-05-23 10:33:15]

noyau: ping

[noyau (Ping after 24h), 2017-05-23 14:09:52]

The CQ bit was checked by noyau@chromium.org

[noyau (Ping after 24h), 2017-05-23 14:09:53]

lgtm

[commit-bot: I haz the power, 2017-05-23 14:10:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 14:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495548592773980,
"parent_rev": "587548914b332653d2ae18e4d10e73ffde0f9406", "commit_rev":
"fd2aa6510e3b05e4ca3816a1b0e42ca59f3051dd"}

[commit-bot: I haz the power, 2017-05-23 14:23:27]

Description was changed from

==========
[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

Rename TabModel ivar from webUsageEnabled_ to _webUsageEnabled
for consistency with the other ivars that use the new convention.

BUG=724282
==========

to

==========
[ios] Clean how WebUsageEnabled flag is restored for WebStateList.

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

Rename TabModel ivar from webUsageEnabled_ to _webUsageEnabled
for consistency with the other ivars that use the new convention.

BUG=724282

Review-Url: https://codereview.chromium.org/2900643003
Cr-Commit-Position: refs/heads/master@{#473886}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd2aa6510e3b05e4ca3816a1b0e4...
==========

[commit-bot: I haz the power, 2017-05-23 14:23:28]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fd2aa6510e3b05e4ca3816a1b0e4...