Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2900593002: Move many more classes to use WebLocalFrameBase over WebLocalFrameImpl. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 6 months ago
Reviewers:
haraken, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-frames_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, Eric Willigers, gavinp+prerender_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mac-reviews_chromium.org, mlamouri+watch-blink_chromium.org, pfeldman+blink_chromium.org, rjwright, shans, Yoav Weiss
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move many more classes to use WebLocalFrameBase over WebLocalFrameImpl. In the majority of these case, we just adjust the header to include core/frame/WebLocalFrameBase.h instead of wevb/WebLocalFrameImpl.h, as the class is just needs to update the definition. In some cases we also needed to change the downcaststs to WebLocalFrameBase. BUG=708879 Review-Url: https://codereview.chromium.org/2900593002 Cr-Commit-Position: refs/heads/master@{#475280} Committed: https://chromium.googlesource.com/chromium/src/+/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -62 lines) Patch
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlayTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 9 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSurroundingText.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebUserGestureIndicator.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/mac/WebSubstringUtil.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/AnimationSimTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/scheduler/ActiveConnectionThrottlingTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
slangley
3 years, 7 months ago (2017-05-24 01:27:10 UTC) #3
sashab
LGTM. What's with the weird commented out code you removed haha
3 years, 7 months ago (2017-05-24 02:10:01 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-24 02:21:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900593002/20001
3 years, 6 months ago (2017-05-29 00:38:19 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 03:01:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd4e07b5898a1a7f287085aa900f...

Powered by Google App Engine
This is Rietveld 408576698