Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2900553004: Reporting: Add histograms. (Closed)

Created:
3 years, 7 months ago by Julia Tuttle
Modified:
3 years, 5 months ago
Reviewers:
rkaplow, jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Add histograms. BUG=704259, 676024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2900553004 Cr-Commit-Position: refs/heads/master@{#484599} Committed: https://chromium.googlesource.com/chromium/src/+/667c0bb37390dc1f4e336151719e30537c1d746d

Patch Set 1 #

Patch Set 2 : revise slightly #

Patch Set 3 : oops, forgot about dependency #

Total comments: 1

Patch Set 4 : Remove unused enum value. #

Patch Set 5 : Clarify wording. #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : Move Reporting histograms out of Net #

Patch Set 10 : rebase #

Patch Set 11 : Fix #includes #

Patch Set 12 : rebase #

Patch Set 13 : rebase #

Patch Set 14 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -67 lines) Patch
M content/browser/net/reporting_service_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +7 lines, -2 lines 0 comments Download
M net/reporting/reporting_browsing_data_remover.cc View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
M net/reporting/reporting_cache.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M net/reporting/reporting_cache.cc View 1 2 3 4 5 6 5 chunks +34 lines, -15 lines 0 comments Download
M net/reporting/reporting_cache_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/reporting/reporting_delivery_agent.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M net/reporting/reporting_delivery_agent_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/reporting/reporting_garbage_collector.cc View 1 1 chunk +10 lines, -6 lines 0 comments Download
M net/reporting/reporting_header_parser.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/reporting/reporting_header_parser.cc View 1 2 3 4 5 6 7 8 5 chunks +85 lines, -22 lines 0 comments Download
M net/reporting/reporting_network_change_observer.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/reporting/reporting_report.h View 1 2 3 3 chunks +25 lines, -0 lines 0 comments Download
M net/reporting/reporting_report.cc View 1 2 3 4 5 6 7 8 2 chunks +40 lines, -2 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +15 lines, -6 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +36 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 73 (61 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 7 months ago (2017-05-22 17:58:44 UTC) #4
Julia Tuttle
PTAL, rkaplow.
3 years, 7 months ago (2017-05-23 17:35:30 UTC) #9
rkaplow
lgtm https://codereview.chromium.org/2900553004/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2900553004/diff/40001/tools/metrics/histograms/histograms.xml#newcode38269 tools/metrics/histograms/histograms.xml:38269: + When Reporting successfully delivers a report, the ...
3 years, 7 months ago (2017-05-24 17:29:56 UTC) #15
commit-bot: I haz the power
This CL has an open dependency (Issue 2881593002 Patch 140001). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-24 20:34:06 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900553004/240001
3 years, 5 months ago (2017-06-30 23:06:53 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/479055)
3 years, 5 months ago (2017-06-30 23:13:40 UTC) #57
Julia Tuttle
PTAL jam for //content/browser.
3 years, 5 months ago (2017-06-30 23:59:11 UTC) #59
jam
lgtm
3 years, 5 months ago (2017-07-05 14:51:03 UTC) #60
jam
lgtm lgtm
3 years, 5 months ago (2017-07-05 14:51:04 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900553004/240001
3 years, 5 months ago (2017-07-05 17:14:33 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900553004/260001
3 years, 5 months ago (2017-07-06 15:13:12 UTC) #70
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 15:17:35 UTC) #73
Message was sent while issue was closed.
Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/667c0bb37390dc1f4e336151719e...

Powered by Google App Engine
This is Rietveld 408576698