Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2900493002: Add a third_party/ copy of Python's zipfile module (Closed)

Created:
3 years, 7 months ago by Kai Ninomiya
Modified:
3 years, 7 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add a third_party/ copy of Python's zipfile module This is a copy of the zipfile module from Python 2.7.13. This snapshot was taken to workaround a bug in older Python versions such as 2.7.3. See https://bugs.python.org/issue6972 and specifically the fix at https://hg.python.org/cpython/rev/0c5fa35c9f12#l3.11 . We encounter the issue due to UNC paths (specifically \\?\ which Catapult uses to avoid long-path errors) which prevents os.path.normpath from fixing up the paths inside the zip upon extraction. Reviewed at https://chromium-review.googlesource.com/c/509108/ TBR=nednguyen@google.com BUG=catapult:#2865 Review-Url: https://codereview.chromium.org/2900493002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2d3f5e75de7cf907515b7ec21272128b08c458ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1816 lines, -1 line) Patch
M dependency_manager/dependency_manager/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M dependency_manager/dependency_manager/dependency_manager_util.py View 1 chunk +1 line, -1 line 0 comments Download
A third_party/zipfile/LICENSE View 1 chunk +255 lines, -0 lines 0 comments Download
A third_party/zipfile/README.chromium View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/zipfile/zipfile_2_7_13.py View 1 chunk +1543 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900493002/1
3 years, 7 months ago (2017-05-20 01:20:34 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 01:22:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698