Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2900463002: [Home] Add some NTP UI polish (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Add some NTP UI polish * Don't show the overview if ChromeTabbedActivity#onStart() if it's already showing. This fixes a bug where the toolbar gets set back to the tab switcher toolbar even though the bottom sheet is open. * Enable omnibox suggestions for the normal NTP UI. * Disable the foreground tab creation animation when Chrome Home is enabled. BUG=724659, 695973 Review-Url: https://codereview.chromium.org/2900463002 Cr-Commit-Position: refs/heads/master@{#473591} Committed: https://chromium.googlesource.com/chromium/src/+/2c459898a1951ee8090812a1ed70716248a1fec3

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-19 22:55:20 UTC) #4
Ted C
lgtm
3 years, 7 months ago (2017-05-19 23:28:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900463002/1
3 years, 7 months ago (2017-05-19 23:33:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298874)
3 years, 7 months ago (2017-05-20 03:37:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900463002/1
3 years, 7 months ago (2017-05-22 15:42:41 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:22:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c459898a1951ee8090812a1ed70...

Powered by Google App Engine
This is Rietveld 408576698