Set the texture base level before generating sRGB mipmaps.

Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2900403003
Cr-Commit-Position: refs/heads/master@{#475349}
Committed: https://chromium.googlesource.com/chromium/src/+/54841760a98142fac982f3ec12064093b8c3a7da

[Geoff Lang, 2017-05-25 14:43:43]

Description was changed from

==========
Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
==========

to

==========
Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-05-25 14:44:14]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 14:44:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-05-25 14:54:06]

Description was changed from

==========
Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-05-25 14:54:06]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2017-05-25 14:54:39]

PTAL, noticed this issue when updating ANGLE's framebuffer validation in
https://chromium-review.googlesource.com/c/506928/

[commit-bot: I haz the power, 2017-05-25 15:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 15:54:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Geoff Lang, 2017-05-25 17:03:25]

nvm on the review, looks like some Mac drivers can't handle this.

[Geoff Lang, 2017-05-25 17:03:36]

geofflang@chromium.org changed reviewers:
- zmo@chromium.org

[Zhenyao Mo, 2017-05-25 17:07:46]

On 2017/05/25 17:03:25, Geoff Lang wrote:
> nvm on the review, looks like some Mac drivers can't handle this.

lgtm
thanks for catching this

[Zhenyao Mo, 2017-05-25 17:09:00]

On 2017/05/25 17:07:46, Zhenyao Mo wrote:
> On 2017/05/25 17:03:25, Geoff Lang wrote:
> > nvm on the review, looks like some Mac drivers can't handle this.
> 
> lgtm
> thanks for catching this

What? Do you know what's the Mac driver issue?  Is it a driver bug we aren't
aware of?

[Geoff Lang, 2017-05-25 17:10:25]

On 2017/05/25 17:09:00, Zhenyao Mo wrote:
> On 2017/05/25 17:07:46, Zhenyao Mo wrote:
> > On 2017/05/25 17:03:25, Geoff Lang wrote:
> > > nvm on the review, looks like some Mac drivers can't handle this.
> > 
> > lgtm
> > thanks for catching this
> 
> What? Do you know what's the Mac driver issue?  Is it a driver bug we aren't
> aware of?

I'll have to dig into it but the mac driver on AMD and Intel is saying the
framebuffer isn't complete.

[Geoff Lang, 2017-05-25 17:32:47]

On 2017/05/25 17:10:25, Geoff Lang wrote:
> On 2017/05/25 17:09:00, Zhenyao Mo wrote:
> > On 2017/05/25 17:07:46, Zhenyao Mo wrote:
> > > On 2017/05/25 17:03:25, Geoff Lang wrote:
> > > > nvm on the review, looks like some Mac drivers can't handle this.
> > > 
> > > lgtm
> > > thanks for catching this
> > 
> > What? Do you know what's the Mac driver issue?  Is it a driver bug we aren't
> > aware of?
> 
> I'll have to dig into it but the mac driver on AMD and Intel is saying the
> framebuffer isn't complete.

Just confirmed that it is returning GL_FRAMEBUFFER_UNSUPPORTED in these cases. 
I'll try only setting the base level for ES drivers.

[Geoff Lang, 2017-05-25 17:45:00]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 17:45:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:24:57]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Geoff Lang, 2017-05-25 20:22:15]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 20:23:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 00:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 00:10:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Geoff Lang, 2017-05-26 17:23:29]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 17:23:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-05-26 17:24:58]

On 2017/05/25 17:32:47, Geoff Lang wrote:
> On 2017/05/25 17:10:25, Geoff Lang wrote:
> > On 2017/05/25 17:09:00, Zhenyao Mo wrote:
> > > On 2017/05/25 17:07:46, Zhenyao Mo wrote:
> > > > On 2017/05/25 17:03:25, Geoff Lang wrote:
> > > > > nvm on the review, looks like some Mac drivers can't handle this.
> > > > 
> > > > lgtm
> > > > thanks for catching this
> > > 
> > > What? Do you know what's the Mac driver issue?  Is it a driver bug we
aren't
> > > aware of?
> > 
> > I'll have to dig into it but the mac driver on AMD and Intel is saying the
> > framebuffer isn't complete.
> 
> Just confirmed that it is returning GL_FRAMEBUFFER_UNSUPPORTED in these cases.

> I'll try only setting the base level for ES drivers.

Ok, PTAL again Mo.  I've re-written it in a way that doesn't require changing
the base level by creating all the mip levels before rendering into any of them.

[commit-bot: I haz the power, 2017-05-26 19:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:08:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Geoff Lang, 2017-05-29 13:46:47]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-05-29 13:46:48]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2900403003/#ps40001
(title: "Fix sizes for mips")

[commit-bot: I haz the power, 2017-05-29 13:46:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 14:50:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496065607713610,
"parent_rev": "fd7049c799296867fa282afcc266239e22ac2be1", "commit_rev":
"54841760a98142fac982f3ec12064093b8c3a7da"}

[commit-bot: I haz the power, 2017-05-29 14:50:55]

Description was changed from

==========
Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Set the texture base level before generating sRGB mipmaps.

GL ES 3.0 considers the framebuffer incomplete if the texture is not mip
complete and the bound mip level is not the base level.  Set the base
level to the attached texture level before rendering each level to avoid
this validation.

BUG=722684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2900403003
Cr-Commit-Position: refs/heads/master@{#475349}
Committed:
https://chromium.googlesource.com/chromium/src/+/54841760a98142fac982f3ec1206...
==========

[commit-bot: I haz the power, 2017-05-29 14:50:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/54841760a98142fac982f3ec1206...