Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2900373002: Remove LLVMFuzzerInitialize from many Blink fuzzers (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
Reviewers:
haraken, mmoroz
CC:
chromium-reviews, Yoav Weiss, blink-reviews-html_chromium.org, iclelland, blink-reviews-style_chromium.org, blink-reviews-css, jbroman+watch_chromium.org, loading-reviews+parser_chromium.org, dglazkov+blink, fuzzing_chromium.org, blink-reviews-bindings_chromium.org, lunalu1, darktears, blink-reviews, apavlov+blink_chromium.org, blink-reviews-frames_chromium.org, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LLVMFuzzerInitialize from many Blink fuzzers This function should only be used if argv is needed, otherwise libfuzzer best practice is to just use static initialization in LLVMFuzzerTestOneInput [1]. This CL also changes the BlinkFuzzerTestSupport to be a class which does all initialization in its constructor. [1]: http://llvm.org/docs/LibFuzzer.html#startup-initialization BUG=693760 Review-Url: https://codereview.chromium.org/2900373002 Cr-Commit-Position: refs/heads/master@{#474993} Committed: https://chromium.googlesource.com/chromium/src/+/fda3f3decbf18cec68fed81b8f48add43c3c64b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -50 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContentsFuzzer.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyFuzzer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerFuzzer.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/TextResourceDecoderFuzzer.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/PngFuzzer.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/TextCodecFuzzer.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/WebIconSizesFuzzer.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyFuzzer.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/json/JSONParserFuzzer.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLFuzzer.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/BlinkFuzzerTestSupport.h View 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/BlinkFuzzerTestSupport.cpp View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Charlie Harrison
mmoroz would you take a first look? I double checked two of these fuzzers manually ...
3 years, 7 months ago (2017-05-24 19:51:13 UTC) #4
Charlie Harrison
+haraken as well, LMK if you would prefer more specific owners.
3 years, 7 months ago (2017-05-25 03:59:26 UTC) #8
haraken
LGTM
3 years, 7 months ago (2017-05-25 04:10:44 UTC) #9
mmoroz
LGTM
3 years, 7 months ago (2017-05-26 06:09:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900373002/1
3 years, 7 months ago (2017-05-26 12:22:03 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 13:35:32 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fda3f3decbf18cec68fed81b8f48...

Powered by Google App Engine
This is Rietveld 408576698