Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 2900333002: Revert of [turbofan] Speculatively optimize string character access. (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
CC:
Hannes Payer (out of office), v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Speculatively optimize string character access. (patchset #1 id:1 of https://codereview.chromium.org/2905623003/ ) Reason for revert: Changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15867 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [turbofan] Speculatively optimize string character access. > > Add a protector cell for string bounds checks that is being used to > protect speculative bounds for String.prototype.charCodeAt and > String.prototype.charAt in TurboFan (and Crankshaft). This way we don't > have the diamond in optimized code, which stands in the way of other > optimizations for charCodeAt that are currently being worked on by > petermarshall@. > > BUG=v8:6391 > TBR=mlippautz@chromium.org > R=petermarshall@chromium.org > > Review-Url: https://codereview.chromium.org/2905623003 > Cr-Commit-Position: refs/heads/master@{#45514} > Committed: https://chromium.googlesource.com/v8/v8/+/9d8bd0551657d60c66b2f96544eecedfba1cba8a TBR=petermarshall@chromium.org,mlippautz@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6391 Review-Url: https://codereview.chromium.org/2900333002 Cr-Commit-Position: refs/heads/master@{#45521} Committed: https://chromium.googlesource.com/v8/v8/+/a07218a56d51698b25dedbab1038f0b6865acfd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -93 lines) Patch
M src/builtins/builtins-string-gen.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +4 lines, -40 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/regress/regress-6391.js View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [turbofan] Speculatively optimize string character access.
3 years, 7 months ago (2017-05-24 17:04:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900333002/1
3 years, 7 months ago (2017-05-24 17:04:35 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 17:04:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a07218a56d51698b25dedbab1038f0b6865...

Powered by Google App Engine
This is Rietveld 408576698