Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2900323002: Revert of base: Avoid unnecessary allocations in base::FindThreadID. (Closed)

Created:
3 years, 6 months ago by reveman
Modified:
3 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Avoid unnecessary allocations in base::FindThreadID. (patchset #2 id:20001 of https://codereview.chromium.org/2882583003/ ) Reason for revert: Causing crash: [FATAL:linux_util.cc(212)] Check failed: split_value_str.size() >= 3u (2 vs. 3) Original issue's description: > base: Avoid unnecessary allocations in base::FindThreadID. > > Improve parsing by using StringTokenizer. > > BUG=708765 > > Review-Url: https://codereview.chromium.org/2882583003 > Cr-Commit-Position: refs/heads/master@{#474077} > Committed: https://chromium.googlesource.com/chromium/src/+/293c72b48fb321d33d6b06147807de9e4000924e TBR=brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708765 Review-Url: https://codereview.chromium.org/2900323002 Cr-Commit-Position: refs/heads/master@{#474297} Committed: https://chromium.googlesource.com/chromium/src/+/7ba6d9f9c06b206a69593c141daf2164f3ca5322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M base/linux_util.cc View 2 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
reveman
Created Revert of base: Avoid unnecessary allocations in base::FindThreadID.
3 years, 6 months ago (2017-05-24 15:35:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900323002/1
3 years, 6 months ago (2017-05-24 15:36:21 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-24 15:37:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ba6d9f9c06b206a69593c141daf...

Powered by Google App Engine
This is Rietveld 408576698