Fix label sorting in results.html

Fix label sorting in results.html

Javascript Map.get() doesn't support default value.

BUG=chromium:725436
Review-Url: https://codereview.chromium.org/2900273002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/91cd4274ef67629920f47c113dd4c591506b25b7

[vovoy, 2017-05-24 03:08:37]

Description was changed from

==========
Fix label sorting in results.html

Sorting labels by start time from newest to oldest. Javascript Map.get()
doesn't support default value.

BUG=chromium:725436
==========

to

==========
Fix label sorting in results.html

Sorting labels by start time from newest to oldest. Javascript Map.get()
doesn't support default value.

BUG=chromium:725436
==========

[vovoy, 2017-05-24 03:08:38]

vovoy@chromium.org changed reviewers:
+ benjhayden@chromium.org, charliea@chromium.org

[vovoy, 2017-05-24 03:08:50]

ptal

[benjhayden, 2017-05-24 18:12:22]

This CL does 2 things: it fixes a bug (yay! thank you!), and changes a feature.

I'm not sure if newest-first makes more sense than oldest-first. In most
timeseries graphs and calendars and other displays of time in LTR languages,
time follows text and marches from left to right.

I could see an argument for making it easy to access newer results, but I think
I'd like to consider alternative solutions before reversing the natural
oldest-newest LTR mapping. For example, many spreadsheet apps allow placing the
name column in a separate scrollable area from the value columns so the user can
scroll horizontally between value columns without losing sight of the name
column. There may be other solutions, but I'd like to have a clear idea of the
problem before deciding on a solution.

Can you narrow this CL to just fix the get() bug, and file a bug report about
reversing the column order?
https://github.com/catapult-project/catapult/issues/new

[charliea (OOO until 10-5), 2017-05-24 18:44:21]

I defer to Ben here :-)

[vovoy, 2017-05-25 01:52:56]

Description was changed from

==========
Fix label sorting in results.html

Sorting labels by start time from newest to oldest. Javascript Map.get()
doesn't support default value.

BUG=chromium:725436
==========

to

==========
Fix label sorting in results.html

Javascript Map.get() doesn't support default value.

BUG=chromium:725436
==========

[vovoy, 2017-05-25 01:53:48]

On 2017/05/24 18:12:22, benjhayden wrote:
> This CL does 2 things: it fixes a bug (yay! thank you!), and changes a
feature.
> 
> I'm not sure if newest-first makes more sense than oldest-first. In most
> timeseries graphs and calendars and other displays of time in LTR languages,
> time follows text and marches from left to right.
> 
> I could see an argument for making it easy to access newer results, but I
think
> I'd like to consider alternative solutions before reversing the natural
> oldest-newest LTR mapping. For example, many spreadsheet apps allow placing
the
> name column in a separate scrollable area from the value columns so the user
can
> scroll horizontally between value columns without losing sight of the name
> column. There may be other solutions, but I'd like to have a clear idea of the
> problem before deciding on a solution.
> 
> Can you narrow this CL to just fix the get() bug, and file a bug report about
> reversing the column order?
> https://github.com/catapult-project/catapult/issues/new

OK. narrowed this CL to fix bug only.

[benjhayden, 2017-05-25 17:38:32]

lgtm, thank you so much!

[vovoy, 2017-05-25 17:42:25]

The CQ bit was checked by vovoy@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:42:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:06:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495734145298130,
"parent_rev": "beaa071a9fbcba43bc23f13e66e3963d398e01ab", "commit_rev":
"91cd4274ef67629920f47c113dd4c591506b25b7"}

[commit-bot: I haz the power, 2017-05-25 18:06:41]

Description was changed from

==========
Fix label sorting in results.html

Javascript Map.get() doesn't support default value.

BUG=chromium:725436
==========

to

==========
Fix label sorting in results.html

Javascript Map.get() doesn't support default value.

BUG=chromium:725436

Review-Url: https://codereview.chromium.org/2900273002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-05-25 18:06:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...