Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2900263003: [Home] Fix BottomSheetNewTabController#testCloseNtp* (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 6 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix BottomSheetNewTabController#testCloseNtp* Previously the tests were not waiting for the correct URL to load so sometimes the NTP wasn't loaded when trying to get the close button. BUG=726032 Review-Url: https://codereview.chromium.org/2900263003 Cr-Commit-Position: refs/heads/master@{#475589} Committed: https://chromium.googlesource.com/chromium/src/+/b80ef087b4b54fedaa98da6ad34112280b5117a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java View 5 chunks +4 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 6 months ago (2017-05-30 16:00:44 UTC) #6
mdjones
lgtm
3 years, 6 months ago (2017-05-30 16:54:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900263003/1
3 years, 6 months ago (2017-05-30 16:58:13 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 17:51:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b80ef087b4b54fedaa98da6ad341...

Powered by Google App Engine
This is Rietveld 408576698