Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 2900253006: WebUI: Fix more violations of no-extra-semi lint rule. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
alemate+watch_chromium.org, apacible+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, rlp+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix more violations of no-extra-semi lint rule. Missed those on the original crrev.com/2902033002. This is in preparation of enabling http://eslint.org/docs/rules/no-extra-semi check during PRESUBMIT. BUG=720034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2900253006 Cr-Commit-Position: refs/heads/master@{#474569} Committed: https://chromium.googlesource.com/chromium/src/+/061530882425512579d47b110cd07fc2fc8dc43c

Patch Set 1 : clang-format #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M chrome/browser/resources/about_nacl.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/arc_support/background.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/cryptotoken/gnubby.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/cryptotoken/hidgnubbydevice.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/cryptotoken/sha256.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/cryptotoken/usbgnubbydevice.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/engagement/site_engagement.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/event_handler.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth_host/post_message_channel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/hotword/nacl_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword/page_audio_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/actions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/types.js View 1 chunk +1 line, -1 line 3 comments Download
M chrome/browser/resources/pdf/browser_api.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/gesture_detector.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/main.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/zoom_manager.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/quota_internals/event_handler.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
dpapad
https://codereview.chromium.org/2900253006/diff/20001/chrome/browser/resources/md_bookmarks/types.js File chrome/browser/resources/md_bookmarks/types.js (right): https://codereview.chromium.org/2900253006/diff/20001/chrome/browser/resources/md_bookmarks/types.js#newcode92 chrome/browser/resources/md_bookmarks/types.js:92: function StoreObserver() {} The semicolon was removed from ESLint, ...
3 years, 7 months ago (2017-05-25 00:45:35 UTC) #10
Dan Beam
lgtm https://codereview.chromium.org/2900253006/diff/20001/chrome/browser/resources/md_bookmarks/types.js File chrome/browser/resources/md_bookmarks/types.js (right): https://codereview.chromium.org/2900253006/diff/20001/chrome/browser/resources/md_bookmarks/types.js#newcode92 chrome/browser/resources/md_bookmarks/types.js:92: function StoreObserver() {} On 2017/05/25 00:45:35, dpapad wrote: ...
3 years, 7 months ago (2017-05-25 00:48:08 UTC) #12
dpapad
https://codereview.chromium.org/2900253006/diff/20001/chrome/browser/resources/md_bookmarks/types.js File chrome/browser/resources/md_bookmarks/types.js (right): https://codereview.chromium.org/2900253006/diff/20001/chrome/browser/resources/md_bookmarks/types.js#newcode92 chrome/browser/resources/md_bookmarks/types.js:92: function StoreObserver() {} On 2017/05/25 at 00:48:08, Dan Beam ...
3 years, 7 months ago (2017-05-25 00:54:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900253006/20001
3 years, 7 months ago (2017-05-25 00:55:44 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 05:42:53 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/061530882425512579d47b110cd0...

Powered by Google App Engine
This is Rietveld 408576698