Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields HasViewportUnits and HasRemUnits
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/2dcf377d46be349720616e66f4bec1a4/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2900253002
Cr-Commit-Position: refs/heads/master@{#475289}
Committed: https://chromium.googlesource.com/chromium/src/+/9453f30a545c2125da8fc2aac5aa9b329c6fe438

[shend, 2017-05-24 01:44:03]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 01:45:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-24 01:46:23]

Description was changed from

==========
Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields InsideLink and HasSimpleUnderline
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/be8153873b212c1cc6f69666e2c0f36d/revisions

BUG=628043
==========

to

==========
Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields HasViewportUnits and HasRemUnits
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/be8153873b212c1cc6f69666e2c0f36d/revisions

BUG=628043
==========

[shend, 2017-05-24 01:48:11]

Description was changed from

==========
Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields HasViewportUnits and HasRemUnits
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/be8153873b212c1cc6f69666e2c0f36d/revisions

BUG=628043
==========

to

==========
Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields HasViewportUnits and HasRemUnits
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/2dcf377d46be349720616e66f4bec1a4/revisions

BUG=628043
==========

[shend, 2017-05-24 01:52:52]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-24 01:52:53]

Hi Naina, PTAL

[nainar, 2017-05-24 06:10:56]

lgtm

[shend, 2017-05-24 06:17:14]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-24 06:17:14]

Hi Eddy, PTAL

[rune, 2017-05-24 06:29:19]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-05-24 06:29:19]

lgtm

[commit-bot: I haz the power, 2017-05-24 07:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:37:52]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-24 07:38:24]

shend@chromium.org changed reviewers:
- meade@chromium.org

[shend, 2017-05-28 22:17:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 22:17:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-28 22:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-28 22:19:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-05-28 22:24:44]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 22:24:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 00:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 00:13:35]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-29 00:15:28]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-29 00:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/2900253002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-29 00:15:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-29 00:16:13]

The CQ bit was unchecked by shend@chromium.org

[shend, 2017-05-29 00:22:06]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 00:22:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:00:54]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-29 05:02:47]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-29 05:02:47]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/2900253002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-29 05:03:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:07:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496034167114780,
"parent_rev": "90832f4a196820a9ff74e7464286330bbd255b69", "commit_rev":
"9453f30a545c2125da8fc2aac5aa9b329c6fe438"}

[commit-bot: I haz the power, 2017-05-29 05:07:12]

Description was changed from

==========
Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields HasViewportUnits and HasRemUnits
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/2dcf377d46be349720616e66f4bec1a4/revisions

BUG=628043
==========

to

==========
Split has_custom_compare_and_copy in ComputedStyleExtraFields.json5.

There are some fields in ComputedStyleBase that do not appear in
CopyNonInheritedFromCached and NonInheritedEqual. The way we prevented
these fields from being generated in these functions is through a
parameter called has_custom_compare_and_copy in ComputedStyleExtraFields
.json5. When it is true, we do not generate code for these fields
inside those functions.

However, some fields, such as HasViewportUnits, do not appear in
NonInheritedEqual but appear in CopyNonInheritedFromCached, or vice
versa. Setting has_custom_compare_and_copy to true would've removed
generated code for both functions, which is not ideal.

This patch splits has_custom_compare_and_copy into custom_copy and
custom_compare. This allows a field to have no generated compare or
copy, or have neither.

This patch also sets the fields HasViewportUnits and HasRemUnits
to have generated copy but not compare, allowing us to remove the
corresponding handwritten code in ComputedStyle.

Diff of generated files:
https://gist.github.com/darrnshn/2dcf377d46be349720616e66f4bec1a4/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2900253002
Cr-Commit-Position: refs/heads/master@{#475289}
Committed:
https://chromium.googlesource.com/chromium/src/+/9453f30a545c2125da8fc2aac5aa...
==========

[commit-bot: I haz the power, 2017-05-29 05:07:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9453f30a545c2125da8fc2aac5aa...