Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2900243003: Revert of Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky. (Closed)

Created:
3 years, 7 months ago by boliu
Modified:
3 years, 7 months ago
Reviewers:
vitaliii
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky. (patchset #1 id:1 of https://codereview.chromium.org/2899133003/ ) Reason for revert: CL that caused DCHECK has been reverted. See bug. Original issue's description: > Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky. > > TBR=boliu@chromium.org > > BUG=725838 > > Review-Url: https://codereview.chromium.org/2899133003 > Cr-Commit-Position: refs/heads/master@{#474272} > Committed: https://chromium.googlesource.com/chromium/src/+/b1711fc89b7d02a4e7aba2a66cb7f291d08a8fac TBR=vitaliii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true BUG=725838 Review-Url: https://codereview.chromium.org/2900243003 Cr-Commit-Position: refs/heads/master@{#474317} Committed: https://chromium.googlesource.com/chromium/src/+/74c84c6d1a2d21f16fb555cb084abb8c63a858dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
boliu
Created Revert of Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky.
3 years, 7 months ago (2017-05-24 15:54:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900243003/1
3 years, 7 months ago (2017-05-24 15:55:35 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 16:19:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74c84c6d1a2d21f16fb555cb084a...

Powered by Google App Engine
This is Rietveld 408576698