Issue 290023002: Move check for existence of generated tests from run-tests.py to presubmit.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290023002: Move check for existence of generated tests from run-tests.py to presubmit.py (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow

Modified:
6 years, 7 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	tools/presubmit.py	View		3 chunks	+10 lines, -1 line	0 comments	Download
	M	tools/run-tests.py	View		1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

lgtm - Assuming output on failures is visible that way.

6 years, 7 months ago (2014-05-15 14:59:56 UTC) #2

Jakob Kummerow

6 years, 7 months ago (2014-05-16 13:18:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21341 (presubmit successful).