tools/run-tests.py - Issue 290023002: Move check for existence of generated tests from run-tests.py to presubmit.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/run-tests.py

Issue 290023002: Move check for existence of generated tests from run-tests.py to presubmit.py (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/run-tests.py

diff --git a/tools/run-tests.py b/tools/run-tests.py

index 6b07574139264778cf116a89bcb43bf583e72841..cfca80f64b7e629062016df38ecab28ada79dc18 100755

--- a/tools/run-tests.py

+++ b/tools/run-tests.py

@@ -336,13 +336,8 @@ def Main():

workspace = os.path.abspath(join(os.path.dirname(sys.argv[0]), ".."))

if not options.no_presubmit:

print ">>> running presubmit tests"

- code = subprocess.call(

+ exit_code = subprocess.call(

[sys.executable, join(workspace, "tools", "presubmit.py")])

- exit_code = code

- code = subprocess.call(

- [sys.executable, join(workspace, "tools", "generate-runtime-tests.py"),

- "check"])

- exit_code = exit_code or code

suite_paths = utils.GetSuitePaths(join(workspace, "test"))

« no previous file with comments | « tools/presubmit.py ('k') | no next file » | no next file with comments »