Moving input filter files and keymap to input directory.

Moving input filter files and keymap to input directory.

Review-Url: https://codereview.chromium.org/2900203002
Cr-Commit-Position: refs/heads/master@{#475009}
Committed: https://chromium.googlesource.com/chromium/src/+/1ae3919d1aa0829792a646417f91b39cf9f29753

[nicholss, 2017-05-23 22:52:47]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[nicholss, 2017-05-23 22:52:55]

nicholss@chromium.org changed reviewers:
+ yuweih@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:53:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-05-23 22:53:36]

PTAL, I am moving the input filter files used in client to the input directory
and was able to remove the source filter restriction from client.

[commit-bot: I haz the power, 2017-05-23 23:11:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:11:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuwei, 2017-05-24 01:30:14]

LGTM once the comment is resolved

https://codereview.chromium.org/2900203002/diff/40001/remoting/client/input/B...
File remoting/client/input/BUILD.gn (right):

https://codereview.chromium.org/2900203002/diff/40001/remoting/client/input/B...
remoting/client/input/BUILD.gn:63: source_set("unit_tests") {
Should we pull out the normalizing_input_filter_unit_tests so that the src
filter override doesn't contaminate other targets?

[nicholss, 2017-05-24 15:46:38]

On 2017/05/24 01:30:14, Yuwei wrote:
> LGTM once the comment is resolved
> 
>
https://codereview.chromium.org/2900203002/diff/40001/remoting/client/input/B...
> File remoting/client/input/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2900203002/diff/40001/remoting/client/input/B...
> remoting/client/input/BUILD.gn:63: source_set("unit_tests") {
> Should we pull out the normalizing_input_filter_unit_tests so that the src
> filter override doesn't contaminate other targets?

Not a bad idea.

[nicholss, 2017-05-24 15:54:29]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 15:54:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 16:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 16:10:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nicholss, 2017-05-24 16:57:02]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:57:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 17:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 17:12:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nicholss, 2017-05-24 17:30:44]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:31:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:48:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Yuwei, 2017-05-24 19:13:30]

https://codereview.chromium.org/2900203002/diff/100001/remoting/client/BUILD.gn
File remoting/client/BUILD.gn (left):

https://codereview.chromium.org/2900203002/diff/100001/remoting/client/BUILD....
remoting/client/BUILD.gn:57: "//remoting/client/input",
Why is this deleted? GestureInterpreter needs TouchInputStrategy to work O_o

I think it also needs RendererProxy in client/display?

[nicholss, 2017-05-25 17:59:40]

https://codereview.chromium.org/2900203002/diff/100001/remoting/client/BUILD.gn
File remoting/client/BUILD.gn (left):

https://codereview.chromium.org/2900203002/diff/100001/remoting/client/BUILD....
remoting/client/BUILD.gn:57: "//remoting/client/input",
On 2017/05/24 19:13:30, Yuwei wrote:
> Why is this deleted? GestureInterpreter needs TouchInputStrategy to work O_o
> 
> I think it also needs RendererProxy in client/display?

gesture_interpreter is part of the !is_nacl block and the rest of the source
does not need it. So I moved it all to where gesture_interpreter is included but
missed moving this.

[nicholss, 2017-05-25 22:41:18]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:42:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 00:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 00:53:35]

Dry run: This issue passed the CQ dry run.

[nicholss, 2017-05-26 15:33:15]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2017-05-26 15:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from yuweih@chromium.org
Link to the patchset: https://codereview.chromium.org/2900203002/#ps120001
(title: "Fix include for input.")

[commit-bot: I haz the power, 2017-05-26 15:33:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 15:38:08]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495812795573400,
"parent_rev": "c290763a1b98e8c9815e87e326b13a314605bf98", "commit_rev":
"2a0b9fd0401aeda385a8e42f0e9fdcaf2952ec31"}

[commit-bot: I haz the power, 2017-05-26 15:38:25]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495812795573400,
"parent_rev": "9383c369577ba6704d02c6827f12dbbab7b28b55", "commit_rev":
"1ae3919d1aa0829792a646417f91b39cf9f29753"}

[commit-bot: I haz the power, 2017-05-26 15:38:36]

Description was changed from

==========
Moving input filter files and keymap to input directory.
==========

to

==========
Moving input filter files and keymap to input directory.

Review-Url: https://codereview.chromium.org/2900203002
Cr-Commit-Position: refs/heads/master@{#475009}
Committed:
https://chromium.googlesource.com/chromium/src/+/1ae3919d1aa0829792a646417f91...
==========

[commit-bot: I haz the power, 2017-05-26 15:38:37]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/1ae3919d1aa0829792a646417f91...