Use relative path in -L and -Wl,-rpath-link

Use relative path in -L and -Wl,-rpath-link

BUG=723856
Review-Url: https://codereview.chromium.org/2900193003
Cr-Commit-Position: refs/heads/master@{#474737}
Committed: https://chromium.googlesource.com/chromium/src/+/f6c6697d774ba4e403008260b0e9419e7db70499

[wychen, 2017-05-24 00:21:33]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 00:23:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:39:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:39:50]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[wychen, 2017-05-24 01:03:27]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 01:04:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 06:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:19:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[wychen, 2017-05-24 06:55:12]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 06:55:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-05-24 08:10:57]

wychen@chromium.org changed reviewers:
+ thakis@chromium.org

[wychen, 2017-05-24 08:10:57]

PTAL

[commit-bot: I haz the power, 2017-05-24 09:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 09:23:10]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-05-24 13:46:36]

The -L change is fine.

Does the rpath change mean that chrome will only run if you run it with
pwd=out/gn, or do they start with $ORIGIN? I vaguely remember some security
concerns with relative rpaths
(https://bugs.chromium.org/p/chromium/issues/detail?id=556843).

[wychen, 2017-05-24 22:24:44]

On 2017/05/24 13:46:36, Nico wrote:
> The -L change is fine.
> 
> Does the rpath change mean that chrome will only run if you run it with
> pwd=out/gn, or do they start with $ORIGIN? I vaguely remember some security
> concerns with relative rpaths
> (https://bugs.chromium.org/p/chromium/issues/detail?id=556843).

-rpath-link is only used at link time, and its value is not included in the
executable, unlike -rpath. Would there still be concerns?

[Nico, 2017-05-25 17:18:11]

Ah, thanks. lgtm.

[Nico, 2017-05-25 17:25:09]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:25:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:00:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495733109072920,
"parent_rev": "323e56e432cb28e97150b1b2a36225b751e3c398", "commit_rev":
"f6c6697d774ba4e403008260b0e9419e7db70499"}

[commit-bot: I haz the power, 2017-05-25 19:01:03]

Description was changed from

==========
Use relative path in -L and -Wl,-rpath-link

BUG=723856
==========

to

==========
Use relative path in -L and -Wl,-rpath-link

BUG=723856

Review-Url: https://codereview.chromium.org/2900193003
Cr-Commit-Position: refs/heads/master@{#474737}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6c6697d774ba4e403008260b0e9...
==========

[commit-bot: I haz the power, 2017-05-25 19:01:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f6c6697d774ba4e403008260b0e9...